> On Jan. 9, 2015, 8:24 a.m., Amareshwari Sriramadasu wrote: > > lens-dist/src/deb/control/postinst, line 43 > > <https://reviews.apache.org/r/29706/diff/1/?file=812945#file812945line43> > > > > lens-config.sh uses following to find jar : > > > > if test -z ${JAVA_HOME} > > then > > JAVA_BIN=`which java` > > JAR_BIN=`which jar` > > else > > JAVA_BIN=${JAVA_HOME}/bin/java > > JAR_BIN=${JAVA_HOME}/bin/jar > > fi > > > > and run expansion thru > > > > $JAR_BIN -xf ${BASEDIR}/webapp/lens-server.war > > > > Is the current change fine? - I'm OK with it, as verison of java > > shouldnt matter for expansion
I guess the default jar binary should work here. - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29706/#review67392 ----------------------------------------------------------- On Jan. 8, 2015, 11:12 a.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29706/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 11:12 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > LENS-181 > > Created postinst script for lens server debian. > Added war-expansion functionality in postinst script. > > > Diffs > ----- > > lens-dist/pom.xml f3c5463 > lens-dist/src/deb/control/postinst PRE-CREATION > pom.xml 079971f > tools/scripts/lens-config.sh 8bd9013 > > Diff: https://reviews.apache.org/r/29706/diff/ > > > Testing > ------- > > Debian installation successful. > > root@34932e553229:/opt/lens# dpkg -i > lens-dist/target/lens-server_2.0.0-SNAPSHOT.deb > (Reading database ... 24319 files and directories currently installed.) > Preparing to unpack .../lens-server_2.0.0-SNAPSHOT.deb ... > Unpacking lens-server (2.0.0-SNAPSHOT) over (2.0.0-SNAPSHOT) ... > Setting up lens-server (2.0.0-SNAPSHOT) ... > / > > > Thanks, > > Himanshu Gahlaut > >
