----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30066/#review68702 -----------------------------------------------------------
Other changes look fine. lens-api/pom.xml <https://reviews.apache.org/r/30066/#comment113086> We are using two spaces for XMLs too. Can we undo this change? - Amareshwari Sriramadasu On Jan. 20, 2015, 9:11 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30066/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 9:11 a.m.) > > > Review request for lens. > > > Bugs: LENS-205 > https://issues.apache.org/jira/browse/LENS-205 > > > Repository: lens > > > Description > ------- > > checkstyle rules added. Formatted lens-api and lens-server-api > > > Diffs > ----- > > checkstyle/src/main/resources/checkstyle.xml > 05de3425ec0fd50b9cd116adc8c5b71e0825958d > lens-api/pom.xml 8e2cddbd9242f6a7e31456252d2b33e01c0b6ecc > lens-api/src/main/java/org/apache/lens/api/APIResult.java > fadfc947bedf32bd6788588cc192856e148123f7 > lens-api/src/main/java/org/apache/lens/api/DateTime.java > d8f4365684f57af5588cbe25427380052710a9c0 > lens-api/src/main/java/org/apache/lens/api/LensConf.java > c2c0bf5c0e13d68582ed4463a8fa9232a12c83bf > lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java > 908284bbec5bc43687fc2f39f5e40d9a3043c4c9 > lens-api/src/main/java/org/apache/lens/api/StringList.java > c037d5c3993570f0ba8bd20314dc8d49543d4e86 > lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java > e9cf60dd202f7e78795749f036abe7268c38e5fb > lens-api/src/main/java/org/apache/lens/api/query/LensPreparedQuery.java > e301cc508462b9803c6da1bda812ed25f07509c8 > lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java > 9af0d069099ceab45c72c2b6474a7c0409680868 > lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java > 6a58b4e61d188d8d02e5ad1030e0bbbf2a040b6e > lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java > 50d4672626843e4873d18d6b04bedafbfd454a76 > lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java > 51165904c365afc9bb250e4159f2670c046a9854 > > lens-api/src/main/java/org/apache/lens/api/query/QueryHandleWithResultSet.java > 7f03edf20d2d88412014752487248b1f4939bc09 > lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java > 29353b69bc41d33e29dfcbe41f14e7bda9a8ce4b > lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java > f977c0b1e76d6f10bf620ced6791ba817caccc81 > lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java > f3d8276e0887abc76730c09f02625fd358156e77 > > lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java > 3ecfa0cb56a414140422f12432afb1761c5d380a > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java > 84c210ea9433a3d541bd0daf94aabc1c82ffa72a > lens-api/src/main/java/org/apache/lens/api/query/ResultColumn.java > dfb04cf0554c17f302df689248b6d2afc6400a7f > lens-api/src/main/java/org/apache/lens/api/query/ResultRow.java > 1ed3b8398dea4340678dd73f9280a5bca2730790 > lens-api/src/main/resources/cube-0.1.xsd > 3bbf7306916a9b7a04274efc3608f8fb5b442316 > lens-api/src/test/java/org/apache/lens/doc/TestGenerateConfigDoc.java > 93d0ac40215771ab84b06ec21d7f8685d733b791 > lens-cli/pom.xml 97fa433e50373f099415b2c68b5dcb861cf91f30 > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 9ae69bd1f7b64229048bbdbf920d77f9ea319e18 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > f1b4ea7da5fb5d3727f5b1ca59b30275549116e2 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > e9c3904d80658f813441d984d50b0581f9ded3a1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > 30712c45885b3c69ef25d5302587e82504703ab8 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > 201b1ee3a1cadf05c66951892e1a895cf327cb03 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > f8833be8ba69d77631fc65cd30dc71616383b94c > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 71848f8072ff17bfcb0d7d26dbdc32a0dc238077 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensNativeTableCommands.java > 9bfb67d5fbdf8298593923a99d27a1a22c13167f > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 9b07a3b40572519519cf71937add908456c42e55 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 15111d3412d35975612de61763ae12656fa28f14 > lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java > c50aebcd30331e2db8266d51cf4e7b71c492b03c > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > c8d038374636b65f21510a71c88d727a6a49e44a > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 9cc2ba1002fe18beaf05e9c22bfb97cc873ff20b > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > f43f53c807d0e726938d3fc3f37fab2adbb021b6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 6e6f9d2c4b9cfd200fc7544f1152beac97c925e7 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 8ecb53684ba6f2f6542fe93c52288fd57d2ca731 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > d3d16ec03a5eec1a0610c52654984dfc7d78a4c0 > lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java > ed4866fc64c8ce94112c8b1a3d0505fe37650dc9 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 2f9e94d8e56860f849018c214954d8e812f51ef3 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 0626618f8491ab2c8edf99b9654033e69507d329 > lens-cli/src/test/resources/dim-local-part.xml > e93552a088f534faa6ab12da0f3f8602cb828cc8 > lens-cli/src/test/resources/dim-local-storage-element.xml > 4688383fa4ae8696616b27d3110b87f290895f4e > lens-cli/src/test/resources/dim1-local-part.xml > 4c541ee85aed7c68c39604055fea61976665fb08 > lens-cli/src/test/resources/dim2-storage-spec.xml > cad6e1130a11c86f51903673a1f018c64167cd79 > lens-cli/src/test/resources/dim_table_storage.xml > 568f0a3b1c99c49721e29c1968520f661e193b95 > lens-cli/src/test/resources/fact-local-storage-element.xml > 7561f38251e740a025025970adeb05ffa1c32a54 > lens-cli/src/test/resources/fact1-local-part.xml > 43ddc62696039eb5a6d9964d6a9018428f2a015d > lens-cli/src/test/resources/fact1-storage-spec.xml > 1e969e4e97c5084beb7b66d07ad9d852e1372595 > lens-cli/src/test/resources/sample-cube.xml > 2ba17fc4385b41d77c3b8fa6989261a17e65f9b0 > lens-cli/src/test/resources/test-dimension.xml > 70bcd091b0e91fcaaa6d8453c67c204194d4fdab > lens-server-api/pom.xml 7e1fd91219f7b53559356e68bef7292d942da59f > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java > 2160f519c804f3dbc84e05ed8698a85ac63aec01 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java > 76f362a513174eace103c4a5f2057cf58ee914ad > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverSelector.java > 004cfad4f154fe4dc42769c8afbbb7f1fce3373b > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverSessionStarted.java > 0e8a1aa1cb2e5d502bee98a0f6b82f1765305c37 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > 145876f4e94dc048e0b242670c7e1b921d8b4b1f > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 840cd8149ad45775fa633837531824fd30c45c41 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java > 68bdecdf935c8f693a0a88b2e9b4dcf2d7044621 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java > 5ad1083e5c60a00f62e953b93ed3cf032e48eed2 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java > fa362387e942e825219bb056608ed0d028017b70 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java > f7d6f08d8dc92c417cb552a5af051b0523b30302 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > cd50c7b195b39f3ba1d20a9d9fa184c66093dcd5 > > lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java > 5f390b6c3d4b522b0311520b92e2c9ca1f421157 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > c1d495462febc4c0f52facf6ccf4f9f242e2980b > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 5dab13ba187f6a638b20c6e65743cc17ca534528 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java > d4be80bf880c561ac13e03bc666433b4f1298141 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/InMemoryOutputFormatter.java > 87c189d1fd0a07001542079249169c77ed71cdd0 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PersistedOutputFormatter.java > 3b50c43726bc1b3dd4875e67fde0372d551d149e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java > 22ff37099f778dfef261e636a5565904407653de > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryAcceptor.java > 6f93f9b3024f36de46a4bc6555d9b3e29f1c58bb > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 07cc54764eb30fd2f1e7c90ef6cf954d36366304 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java > 5a1a6051c88793460b2c9018efe121eccbc2247d > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java > c77bbf61ed06453b981adfd0cae5b922a64c8b07 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 9b1e8e271918524c730122c3cae0b2718f5c0a34 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java > e55c417fb94d0b3382304aaddf268e0e9e768359 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java > b95a36a2d1836de02d4842f0077535b086db8677 > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > 67b694a92280e09d648c34c3bc587cae5b8fce2e > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > def1d639d2687cead05bb72336ef944fff7d4072 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java > 7ed2fd0024afb80bd812ac8e29a98b0515530ed0 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java > 749ef60a7c7df56b2a8ef20833b6477d9039d459 > > Diff: https://reviews.apache.org/r/30066/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
