----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30066/#review68713 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 20, 2015, 12:36 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30066/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 12:36 p.m.) > > > Review request for lens. > > > Bugs: LENS-205 > https://issues.apache.org/jira/browse/LENS-205 > > > Repository: lens > > > Description > ------- > > checkstyle rules added. > > import order: > 1. java > 2. blank line > 3. javax > 4. blank line > 5. org.apache.lens > 6. blank line > 7. org.apache > 8. blank line > 9. org > 10. blank line > 11. others > > > Checkstyle rules re-enabled: > 1. ensure file ending with newline character > 2. no trailing whitespaces in any line > > > Enforced failure on checkstyle violation in the following modules: > > 1. lens-api > 2. lens-server-api > 3. lens-storage-db > 4. lens-query-lib > > This way, any new code in already clean modules would be checkstyle > certified. > > Remaining modules: > > 1. lens-cli > 2. lens-client > 3. lens-client-dist > 4. lens-cube > 5. lens-dist > 6. lens-docker > 7. lens-driver-hive > 8. lens-driver-impala > 9. lens-driver-jdbc > 10. lens-examples > 11. lens-ml-lib > 12. lens-server > > Let's clean them one by one and as we clean a module, enable fail on > violation on that. Once all modules have fail on violation enabled, we can > remove that config from individual poms and keep only in parent pom. > > > Diffs > ----- > > checkstyle/src/main/resources/checkstyle.xml > 05de3425ec0fd50b9cd116adc8c5b71e0825958d > lens-api/pom.xml 8e2cddbd9242f6a7e31456252d2b33e01c0b6ecc > lens-api/src/main/java/org/apache/lens/api/APIResult.java > fadfc947bedf32bd6788588cc192856e148123f7 > lens-api/src/main/java/org/apache/lens/api/DateTime.java > d8f4365684f57af5588cbe25427380052710a9c0 > lens-api/src/main/java/org/apache/lens/api/LensConf.java > c2c0bf5c0e13d68582ed4463a8fa9232a12c83bf > lens-api/src/main/java/org/apache/lens/api/LensException.java > 9a4f173fdafd91f40b6af9fab2e2b4266a66a289 > lens-api/src/main/java/org/apache/lens/api/LensSessionHandle.java > 908284bbec5bc43687fc2f39f5e40d9a3043c4c9 > lens-api/src/main/java/org/apache/lens/api/Priority.java > 8d6390b63f2120f997b4f39e313fd4bd233a186a > lens-api/src/main/java/org/apache/lens/api/StringList.java > c037d5c3993570f0ba8bd20314dc8d49543d4e86 > lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java > e9cf60dd202f7e78795749f036abe7268c38e5fb > lens-api/src/main/java/org/apache/lens/api/query/LensPreparedQuery.java > e301cc508462b9803c6da1bda812ed25f07509c8 > lens-api/src/main/java/org/apache/lens/api/query/LensQuery.java > 9af0d069099ceab45c72c2b6474a7c0409680868 > lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java > 6a58b4e61d188d8d02e5ad1030e0bbbf2a040b6e > lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java > 50d4672626843e4873d18d6b04bedafbfd454a76 > lens-api/src/main/java/org/apache/lens/api/query/QueryHandle.java > 51165904c365afc9bb250e4159f2670c046a9854 > > lens-api/src/main/java/org/apache/lens/api/query/QueryHandleWithResultSet.java > 7f03edf20d2d88412014752487248b1f4939bc09 > lens-api/src/main/java/org/apache/lens/api/query/QueryPlan.java > 29353b69bc41d33e29dfcbe41f14e7bda9a8ce4b > lens-api/src/main/java/org/apache/lens/api/query/QueryPrepareHandle.java > f977c0b1e76d6f10bf620ced6791ba817caccc81 > lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java > f3d8276e0887abc76730c09f02625fd358156e77 > > lens-api/src/main/java/org/apache/lens/api/query/QueryResultSetMetadata.java > 3ecfa0cb56a414140422f12432afb1761c5d380a > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java > 84c210ea9433a3d541bd0daf94aabc1c82ffa72a > lens-api/src/main/java/org/apache/lens/api/query/QuerySubmitResult.java > a1986b6794d0fc93617da200842be974855e4dd2 > lens-api/src/main/java/org/apache/lens/api/query/ResultColumn.java > dfb04cf0554c17f302df689248b6d2afc6400a7f > lens-api/src/main/java/org/apache/lens/api/query/ResultColumnType.java > 824f2ce27f90820f6e39f2aa2c14a14e1b2bc4c7 > lens-api/src/main/java/org/apache/lens/api/query/ResultRow.java > 1ed3b8398dea4340678dd73f9280a5bca2730790 > lens-api/src/main/java/org/apache/lens/api/query/SubmitOp.java > 8affd1df859da9dbf1cf49dd95496f142d6a60dd > lens-api/src/main/resources/cube-0.1.xsd > 3bbf7306916a9b7a04274efc3608f8fb5b442316 > lens-api/src/test/java/org/apache/lens/doc/TestGenerateConfigDoc.java > 93d0ac40215771ab84b06ec21d7f8685d733b791 > lens-query-lib/pom.xml e76259e147d0c9190e182cde91bc5f57a6b05eff > > lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java > 69df8ee14f091c8ccc781b0a84a49ac7f139dd48 > > lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractOutputFormatter.java > 92ec70bccf471ab26b1b4095a0c6b43b4602fb15 > lens-query-lib/src/main/java/org/apache/lens/lib/query/CSVSerde.java > 6c727978d34e0653d1af510268766c9c077dc77b > lens-query-lib/src/main/java/org/apache/lens/lib/query/FileFormatter.java > faf8b401bb70c01b0a44fdf05014790a61c76912 > > lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java > 657c5eb820c9a19ddcda149b28590a967bbde94a > > lens-query-lib/src/main/java/org/apache/lens/lib/query/FileSerdeFormatter.java > d60cad07487d238c5099e45aaf271a978371a4aa > > lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java > 8bb567f0639cc9626de1e3e83500a16489fb443e > lens-query-lib/src/main/java/org/apache/lens/lib/query/JSonSerde.java > e4b9785d688eecc0aa621389a0e14b7405688f1c > > lens-query-lib/src/main/java/org/apache/lens/lib/query/LensFileOutputFormat.java > 8dfd2050debbaa0a6ba5a7b1b2330bc7cd9eaac1 > > lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java > 5a3cc95f1d8c18b8470db8f0b93a7e9f29afe47b > > lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java > 86bcbb6c1002ba60bbbc112342b4c0c3fc1b8aca > > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java > 3b5400b1212c361f97f71259004d36615418a86b > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestCSVSerde.java > 3ade63441cac93fb58c875235227cd7920be34df > > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFilePersistentFormatter.java > 8ad2b232d37888068b66272357d421ed11cbd6dd > > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFileSerdeFormatter.java > ad2071576b96ac28fa44885149a05544522e61ab > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestJSONSerde.java > 746353e6dc03ba2276491f2824f95300aa6cd13c > lens-server-api/pom.xml 7e1fd91219f7b53559356e68bef7292d942da59f > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java > 2160f519c804f3dbc84e05ed8698a85ac63aec01 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java > 76f362a513174eace103c4a5f2057cf58ee914ad > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverSelector.java > 004cfad4f154fe4dc42769c8afbbb7f1fce3373b > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverSessionStarted.java > 0e8a1aa1cb2e5d502bee98a0f6b82f1765305c37 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > 145876f4e94dc048e0b242670c7e1b921d8b4b1f > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 840cd8149ad45775fa633837531824fd30c45c41 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java > 68bdecdf935c8f693a0a88b2e9b4dcf2d7044621 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java > 5ad1083e5c60a00f62e953b93ed3cf032e48eed2 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java > 2aafd447f34875e0d9e9dd0d5cd53a270b6b4311 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/AsyncEventListener.java > fa362387e942e825219bb056608ed0d028017b70 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java > f7d6f08d8dc92c417cb552a5af051b0523b30302 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > cd50c7b195b39f3ba1d20a9d9fa184c66093dcd5 > > lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java > 5f390b6c3d4b522b0311520b92e2c9ca1f421157 > > lens-server-api/src/main/java/org/apache/lens/server/api/priority/RangeConf.java > 0ae8c66ce069ece4740cc8ffa383c4247da38447 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > c1d495462febc4c0f52facf6ccf4f9f242e2980b > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 5dab13ba187f6a638b20c6e65743cc17ca534528 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java > d4be80bf880c561ac13e03bc666433b4f1298141 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > e2e6de5ad9b0a6030ef33ccdb91cf4abf2ea0b9a > > lens-server-api/src/main/java/org/apache/lens/server/api/query/InMemoryOutputFormatter.java > 87c189d1fd0a07001542079249169c77ed71cdd0 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PersistedOutputFormatter.java > 3b50c43726bc1b3dd4875e67fde0372d551d149e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java > 22ff37099f778dfef261e636a5565904407653de > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryAcceptor.java > 6f93f9b3024f36de46a4bc6555d9b3e29f1c58bb > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 07cc54764eb30fd2f1e7c90ef6cf954d36366304 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEnded.java > 5a1a6051c88793460b2c9018efe121eccbc2247d > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryEvent.java > c77bbf61ed06453b981adfd0cae5b922a64c8b07 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 9b1e8e271918524c730122c3cae0b2718f5c0a34 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java > e55c417fb94d0b3382304aaddf268e0e9e768359 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryRewriter.java > b95a36a2d1836de02d4842f0077535b086db8677 > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > 67b694a92280e09d648c34c3bc587cae5b8fce2e > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > def1d639d2687cead05bb72336ef944fff7d4072 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockFailDriver.java > 7ed2fd0024afb80bd812ac8e29a98b0515530ed0 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockQueryContext.java > 749ef60a7c7df56b2a8ef20833b6477d9039d459 > lens-storage-db/pom.xml 860a1c20b527e5f322eed232877cf5380e6e1e19 > lens-storage-db/src/main/java/org/apache/lens/storage/db/DBSerde.java > c15713932f066890b190bad554147eb0d8c58eba > lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java > f3fdbca906cfc1d6eb9f88bfbc25a7516f172304 > > lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorageHandler.java > 351d7223f165487b7d64b219952089eee4e1770e > lens-storage-db/src/test/java/org/apache/lens/storage/db/TestDBStorage.java > 3950190f625c5e9e9440f5c687418b62d4833a5d > lens-storage-db/src/test/resources/hive-site.xml > 87d534b21e5db54ef8013d4e4d3cc1e18b324bdb > > Diff: https://reviews.apache.org/r/30066/diff/ > > > Testing > ------- > > mvn clean install -DskipTests succeeds. > > > Thanks, > > Rajat Khandelwal > >
