> On Jan. 28, 2015, 10:35 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java, > > line 48 > > <https://reviews.apache.org/r/30359/diff/2/?file=838583#file838583line48> > > > > This change wont put the filters correctly. > > > > For we have : > > (it = d1 or d2 or .... d27) or > > (pt=d28-00 and it=d27-22) or (pt=d28-00 and it=d27-23) > > > > This will change pt in (d28-00) and it in ( d1, d2, ..., d27, d27-22, > > d27-23). > > > > The above change is losing the coupling of AND constraint between pt > > and it.
Planning to use a hybrid approach 1. If the time range filter contains multiple columns, use it as is, and combine all such filters with an OR 2. If the time range filter contains only a single column all filters for that column will be combined in an IN clause - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30359/#review69986 ----------------------------------------------------------- On Jan. 28, 2015, 10:13 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30359/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2015, 10:13 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-35 > https://issues.apache.org/jira/browse/LENS-35 > > > Repository: lens > > > Description > ------- > > LENS-35 Queries failing with monthly time range at hourly granularity > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/InTimeRangeWriter.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 6733e4adb423238b9e4f326219092960a57d2b45 > > Diff: https://reviews.apache.org/r/30359/diff/ > > > Testing > ------- > > Added unit test to validate that partition in clause gets parsed > successfully. Also validated failure with OR partition clause. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s] > [INFO] Lens .............................................. SUCCESS [1.473s] > [INFO] Lens API .......................................... SUCCESS [16.719s] > [INFO] Lens API for server and extensions ................ SUCCESS [7.433s] > [INFO] Lens Cube ......................................... SUCCESS [8:53.474s] > [INFO] Lens DB storage ................................... SUCCESS [36.185s] > [INFO] Lens Query Library ................................ SUCCESS [9.052s] > [INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s] > [INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s] > [INFO] Lens Server ....................................... SUCCESS > [17:16.966s] > [INFO] Lens client ....................................... SUCCESS [33.318s] > [INFO] Lens CLI .......................................... SUCCESS [3:50.482s] > [INFO] Lens Examples ..................................... SUCCESS [2.249s] > [INFO] Lens Distribution ................................. SUCCESS [0.468s] > [INFO] Lens Client Distribution .......................... SUCCESS [2.481s] > [INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s] > [INFO] Lens Regression ................................... SUCCESS [0.417s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 40:24.593s > [INFO] Finished at: Wed Jan 28 12:41:19 IST 2015 > [INFO] Final Memory: 113M/582M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Jaideep dhok > >
