-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30359/
-----------------------------------------------------------

(Updated Jan. 28, 2015, 12:03 p.m.)


Review request for lens and Amareshwari Sriramadasu.


Changes
-------

Using hybrid approach to incorporate multiple partition columns.

Example rewritten query - 
```
@@ HQL with IN and OR: SELECT ( testcube . dim1 ), max(( testcube . msr3 )), 
sum(( testcube . msr2 )) FROM TestQueryRewrite.c2_summary1 testcube WHERE 
((testcube.pt != 'latest' AND testcube.et != 'latest') AND (((((((( testcube . 
pt ) =  '2015-01-28-00' ) and (( testcube . it ) =  '2015-01-27-20' )) or ((( 
testcube . pt ) =  '2015-01-28-01' ) and (( testcube . it ) =  '2015-01-27-21' 
))) or ((( testcube . pt ) =  '2015-01-28-02' ) and (( testcube . it ) =  
'2015-01-27-22' ))) or ((( testcube . pt ) =  '2015-01-28-03' ) and (( testcube 
. it ) =  '2015-01-27-23' ))) or ( testcube . it ) in ( '2015-01-26-17'  ,  
'2015-01-26-18'  ,  '2015-01-26-19'  ,  '2015-01-26-20'  ,  '2015-01-26-21'  ,  
'2015-01-26-22'  ,  '2015-01-26-23'  ,  '2015-01-27'  ,  '2015-01-28-00'  ,  
'2015-01-28-01'  ,  '2015-01-28-02'  ,  '2015-01-28-03'  ,  '2015-01-28-04'  ,  
'2015-01-28-05'  ,  '2015-01-28-06'  ,  '2015-01-28-07'  ,  '2015-01-28-08'  ,  
'2015-01-28-09'  ,  '2015-01-28-10'  ,  '2015-01-28-11'  ,  '201
 5-01-28-12'  ,  '2015-01-28-13'  ,  '2015-01-28-14'  ,  '2015-01-28-15'  ,  
'2015-01-28-16' )))) GROUP BY ( testcube . dim1 )
```


Bugs: LENS-35
    https://issues.apache.org/jira/browse/LENS-35


Repository: lens


Description
-------

LENS-35 Queries failing with monthly time range at hourly granularity


Diffs (updated)
-----

  
lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java 
PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
6733e4adb423238b9e4f326219092960a57d2b45 

Diff: https://reviews.apache.org/r/30359/diff/


Testing
-------

Added unit test to validate that partition in clause gets parsed successfully. 
Also validated failure with OR partition clause.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [9.514s]
[INFO] Lens .............................................. SUCCESS [1.473s]
[INFO] Lens API .......................................... SUCCESS [16.719s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.433s]
[INFO] Lens Cube ......................................... SUCCESS [8:53.474s]
[INFO] Lens DB storage ................................... SUCCESS [36.185s]
[INFO] Lens Query Library ................................ SUCCESS [9.052s]
[INFO] Lens Hive Driver .................................. SUCCESS [5:22.688s]
[INFO] Lens Driver for Cloudera Impala ................... SUCCESS [7.933s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [42.304s]
[INFO] Lens Server ....................................... SUCCESS [17:16.966s]
[INFO] Lens client ....................................... SUCCESS [33.318s]
[INFO] Lens CLI .......................................... SUCCESS [3:50.482s]
[INFO] Lens Examples ..................................... SUCCESS [2.249s]
[INFO] Lens Distribution ................................. SUCCESS [0.468s]
[INFO] Lens Client Distribution .......................... SUCCESS [2.481s]
[INFO] Lens ML Lib ....................................... SUCCESS [2:10.550s]
[INFO] Lens Regression ................................... SUCCESS [0.417s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 40:24.593s
[INFO] Finished at: Wed Jan 28 12:41:19 IST 2015
[INFO] Final Memory: 113M/582M
[INFO] ------------------------------------------------------------------------


Thanks,

Jaideep dhok

Reply via email to