----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30251/#review70544 -----------------------------------------------------------
You don't need to convert between `Long` and `long`. Java takes care of that itself by Autoboxing and Unboxing. http://docs.oracle.com/javase/tutorial/java/data/autoboxing.html - Rajat Khandelwal On Jan. 30, 2015, 2:52 p.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30251/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 2:52 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-68 > https://issues.apache.org/jira/browse/LENS-68 > > > Repository: lens > > > Description > ------- > > Dim attributes should contain number of possible distinct values it can take. > This can be an approximate number. This would give an idea of how big the > grouping will be when an attribute is chosen for groupby expressions > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f75ea60 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > 2c0e70d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/InlineDimAttribute.java > 140f284 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 6b81cae > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 4f283ad > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > ab06db9 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > f9e9f3d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 2a9566f > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 8bf9f81 > > Diff: https://reviews.apache.org/r/30251/diff/ > > > Testing > ------- > > Added a checks in the existing unit tests > > > Thanks, > > Raju Bairishetti > >
