> On April 4, 2015, 12:39 p.m., Himanshu Gahlaut wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java, > > line 113 > > <https://reviews.apache.org/r/30251/diff/4/?file=911870#file911870line113> > > > > Can @ToString(callSuper=true) of lombok work in place of this ?
+1 > On April 4, 2015, 12:39 p.m., Himanshu Gahlaut wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java, > > line 83 > > <https://reviews.apache.org/r/30251/diff/4/?file=911870#file911870line83> > > > > Parsing exception not handled here. Yes. Let's set it to absent in such cases, since it's optional anyway. And add a warn log. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30251/#review78883 ----------------------------------------------------------- On April 8, 2015, 8:32 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30251/ > ----------------------------------------------------------- > > (Updated April 8, 2015, 8:32 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-68 > https://issues.apache.org/jira/browse/LENS-68 > > > Repository: lens > > > Description > ------- > > Dim attributes should contain number of possible distinct values it can take. > This can be an approximate number. This would give an idea of how big the > grouping will be when an attribute is chosen for groupby expressions > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 18ee682 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > c4efe52 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/InlineDimAttribute.java > e23bd8c > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 7e6360e > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 0be8e5f > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > 859b344 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > baa659c > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 138797e > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 933714c > > Diff: https://reviews.apache.org/r/30251/diff/ > > > Testing > ------- > > Added a checks in the existing unit tests > > > Thanks, > > Raju Bairishetti > >
