> On April 7, 2015, 11:38 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 1216 > > <https://reviews.apache.org/r/32916/diff/1/?file=918781#file918781line1216> > > > > Should this be BadRequest or something else? Calling out for other's > > opinion.
https://issues.apache.org/jira/browse/LENS-488 should cover this. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32916/#review79130 ----------------------------------------------------------- On April 7, 2015, 11:11 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32916/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 11:11 a.m.) > > > Review request for lens. > > > Bugs: LENS-456 and LENS-457 > https://issues.apache.org/jira/browse/LENS-456 > https://issues.apache.org/jira/browse/LENS-457 > > > Repository: lens > > > Description > ------- > > LENS-457: Configurability in QueryExecutionServiceImpl > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 6326b42 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 3e0e0db > lens-server/src/main/resources/lensserver-default.xml c153193 > > lens-server/src/test/java/org/apache/lens/server/query/BlahQueryAcceptor.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > bce0ca9 > lens-server/src/test/resources/lens-site.xml d966f47 > src/site/apt/admin/config.apt 2462f85 > > Diff: https://reviews.apache.org/r/32916/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
