----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32916/#review79163 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java <https://reviews.apache.org/r/32916/#comment128332> >>> LOG.info("initialized acceptors: " + queryAcceptors); Any advantage of printing this logline in every iteration of for loop. Same initialized acceptor in the list will be printed more than once. We can add a logline in try block after line 272 to print every acceptor which is successfully initialized only once. - Himanshu Gahlaut On April 7, 2015, 8:25 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32916/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 8:25 a.m.) > > > Review request for lens. > > > Bugs: LENS-456 and LENS-457 > https://issues.apache.org/jira/browse/LENS-456 > https://issues.apache.org/jira/browse/LENS-457 > > > Repository: lens > > > Description > ------- > > LENS-457: Configurability in QueryExecutionServiceImpl > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 6326b42ed54447eddcd001842b41e88c5eff9f28 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 3e0e0db81bf5a5e4bb165ab5ccd12494e10fed05 > lens-server/src/main/resources/lensserver-default.xml > c153193a73a92c1d5c55b358a3e4a4d91db44978 > > lens-server/src/test/java/org/apache/lens/server/query/BlahQueryAcceptor.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > bce0ca93e8fd4432ae85b08823ff6bc1df968da2 > lens-server/src/test/resources/lens-site.xml > d966f4728153e6f69b187ec505b53d38afa38309 > src/site/apt/admin/config.apt 2462f85938b412acc07e561f13d3ac1750d3a536 > > Diff: https://reviews.apache.org/r/32916/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.264s] > [INFO] Lens .............................................. SUCCESS [1.829s] > [INFO] Lens API .......................................... SUCCESS [5.301s] > [INFO] Lens API for server and extensions ................ SUCCESS [6.757s] > [INFO] Lens Cube ......................................... SUCCESS [2:13.985s] > [INFO] Lens DB storage ................................... SUCCESS [10.699s] > [INFO] Lens Query Library ................................ SUCCESS [4.434s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:35.062s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [19.631s] > [INFO] Lens Server ....................................... SUCCESS [4:46.450s] > [INFO] Lens client ....................................... SUCCESS [20.883s] > [INFO] Lens CLI .......................................... SUCCESS [2:44.057s] > [INFO] Lens Examples ..................................... SUCCESS [0.846s] > [INFO] Lens Distribution ................................. SUCCESS [10.074s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:01.108s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.463s] > [INFO] Lens Regression ................................... SUCCESS [0.466s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 14:47.190s > [INFO] Finished at: Tue Apr 07 08:01:56 UTC 2015 > [INFO] Final Memory: 108M/1113M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
