> On Jan. 27, 2015, 5:08 a.m., Jaideep dhok wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java, > > line 369 > > <https://reviews.apache.org/r/30250/diff/2/?file=833456#file833456line369> > > > > @Raju, Instead of this unit test, we should check if the events are > > getting generated when sessions are closed/opened. We already have a > > TestSessionResource. Can we add few testcases for events there? > > > > What we are testing here is essentially just event send and receive, > > that has been already verified in other test cases in this class.
I have added a unit test for validating the session events metrics in TestSessionResource test class. That covers whether session events are getting generated or not. > On Jan. 27, 2015, 5:08 a.m., Jaideep dhok wrote: > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java, > > line 414 > > <https://reviews.apache.org/r/30250/diff/2/?file=833455#file833455line414> > > > > I also think one SessionClosed event is enough. Main motivation behind > > these events is to allow other services to manage per session resources. > > From that perspective SessionExpired and SessionClosed are the same. Did not make any changes with respect to this review comment. Can we have single SessionClosed event for all closing related things(expiring & closing) ? - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review69749 ----------------------------------------------------------- On April 22, 2015, 1:22 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 1:22 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71a1f5b > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 90137e1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > cd1fbd8 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > e4fb812 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > ec752ff > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 00df104 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService > > > Thanks, > > Raju Bairishetti > >
