----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review82377 -----------------------------------------------------------
One more comment wrt documentation. Please update monitoring doc with new counters added. Sorry missed this earlier. - Amareshwari Sriramadasu On April 30, 2015, 3:15 p.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 3:15 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71a1f5b > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 90137e1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > cd1fbd8 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > e4fb812 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > ec752ff > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java > c1cb9da > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 00df104 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService and TestSessionResource > > incubating-SNAPSHOT/lens-regression-2.2.0-beta-incubating-SNAPSHOT-tests.jar > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.360s] > [INFO] Lens .............................................. SUCCESS [2.922s] > [INFO] Lens API .......................................... SUCCESS [17.324s] > [INFO] Lens API for server and extensions ................ SUCCESS [23.467s] > [INFO] Lens Cube ......................................... SUCCESS [4:14.366s] > [INFO] Lens DB storage ................................... SUCCESS [1:03.938s] > [INFO] Lens Query Library ................................ SUCCESS [1:00.936s] > [INFO] Lens Hive Driver .................................. SUCCESS [7:21.818s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [32.129s] > [INFO] Lens Server ....................................... SUCCESS [5:19.086s] > [INFO] Lens client ....................................... SUCCESS [40.811s] > [INFO] Lens CLI .......................................... SUCCESS [2:47.861s] > [INFO] Lens Examples ..................................... SUCCESS [9.312s] > [INFO] Lens Distribution ................................. SUCCESS [10.739s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:17.383s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [3.273s] > [INFO] Lens Regression ................................... SUCCESS [0.508s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 25:29.184s > [INFO] Finished at: Wed Apr 29 03:25:23 UTC 2015 > [INFO] Final Memory: 116M/1466M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Raju Bairishetti > >
