----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review81286 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/LensService.java <https://reviews.apache.org/r/30250/#comment131595> Made it public for accessing from MetricServiceImpl to know the number of sessions opened (gauge metric) lens-server/src/main/java/org/apache/lens/server/LensService.java <https://reviews.apache.org/r/30250/#comment131593> This is an existing getter method in QueryExecutionServiceImpl. I just moved the method to here to make it available to SessionService as well. - Raju Bairishetti On April 22, 2015, 1:22 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated April 22, 2015, 1:22 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71a1f5b > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 90137e1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > cd1fbd8 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > e4fb812 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > ec752ff > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 00df104 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService > > > Thanks, > > Raju Bairishetti > >
