> On April 27, 2015, 11:59 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java, > > line 33 > > <https://reviews.apache.org/r/30250/diff/5/?file=942606#file942606line33> > > > > Is this required? How is CLOSED state different from EXPIRED? From > > state transitions, they are the same. > > > > Similar OPEN and RESTORE are the same. > > > > I would say let us remove this status enum.
EXPIRED is added just to know how many sessions were inactive(idle for longer than expired interval) and how many sessions were closed by the users. Eventually, all inactive(expired) sessions will be closed periodically. - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30250/#review81674 ----------------------------------------------------------- On April 28, 2015, 1:47 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30250/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 1:47 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-186 > https://issues.apache.org/jira/browse/LENS-186 > > > Repository: lens > > > Description > ------- > > If a service is maintaining some session specific data events like session > started or session closed would be useful for init/cleanup of resources. > > This would be also useful in maintaining session history. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71a1f5b > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > cec7343 > lens-server/src/main/java/org/apache/lens/server/LensService.java bd8699b > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 90137e1 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > cd1fbd8 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > e4fb812 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > ed906fe > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > ec752ff > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 00df104 > > Diff: https://reviews.apache.org/r/30250/diff/ > > > Testing > ------- > > Added a unit test in TestEventService > > > Thanks, > > Raju Bairishetti > >
