----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33669/#review82626 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java <https://reviews.apache.org/r/33669/#comment133401> Can we add expressionSpec to the set only if the given exprSpec is valid? ExprSpec e = expressions[i]; // validate expresionSepc expressionSet.add(e); Can we have a method like validateExprSec() for validating the exprSpec? - Raju Bairishetti On April 30, 2015, 7:13 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33669/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 7:13 a.m.) > > > Review request for lens and Jaideep dhok. > > > Bugs: LENS-176 > https://issues.apache.org/jira/browse/LENS-176 > > > Repository: lens > > > Description > ------- > > - Added multiple expressions in XExprColumn > - Included optional start and end time for an expression in the expression > spec. > - Update examples with a measure and an attribute with multiple expressions, > and with start and end times specified. > - Update server tests with multiple expressions. > - Also fixed an existing issue with examples, where time format specified is > wrong. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 24d0d64 > lens-cli/src/test/resources/sample-cube.xml 4908f85 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java > 3618733 > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > df4cf25 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > fa23b8e > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > d4c109a > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java > 51db143 > lens-examples/src/main/resources/customer.xml e78dab2 > lens-examples/src/main/resources/product.xml 8093561 > lens-examples/src/main/resources/sales-cube.xml 951ace9 > lens-examples/src/main/resources/sample-cube.xml f24a8cc > lens-examples/src/main/resources/sample-db-only-dimension.xml 63a8bf8 > lens-examples/src/main/resources/sample-dimension.xml af4ab21 > lens-examples/src/main/resources/sample-dimension2.xml d1ac80d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 3cf7011 > > lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java > dbcca24 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > a35a8ff > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > ed4749f > > Diff: https://reviews.apache.org/r/33669/diff/ > > > Testing > ------- > > Created and Populated sample metastore, verified all expressions are fine, > thier start and end times. Example queries running fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.040s] > [INFO] Lens .............................................. SUCCESS [2.715s] > [INFO] Lens API .......................................... SUCCESS [17.572s] > [INFO] Lens API for server and extensions ................ SUCCESS [23.153s] > [INFO] Lens Cube ......................................... SUCCESS [3:25.745s] > [INFO] Lens DB storage ................................... SUCCESS [21.129s] > [INFO] Lens Query Library ................................ SUCCESS [18.543s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:48.784s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [31.543s] > [INFO] Lens Server ....................................... SUCCESS [5:14.815s] > [INFO] Lens client ....................................... SUCCESS [37.175s] > [INFO] Lens CLI .......................................... SUCCESS [3:06.258s] > [INFO] Lens Examples ..................................... SUCCESS [9.195s] > [INFO] Lens Distribution ................................. SUCCESS [10.532s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:16.330s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.900s] > [INFO] Lens Regression ................................... SUCCESS [6.230s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:55.613s > [INFO] Finished at: Thu Apr 30 07:04:41 UTC 2015 > [INFO] Final Memory: 112M/1207M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
