> On May 6, 2015, 6:50 a.m., Rajat Khandelwal wrote: > > lens-cli/src/test/resources/sample-cube.xml, line 32 > > <https://reviews.apache.org/r/33669/diff/2/?file=946093#file946093line32> > > > > What does it mean when none of the start and end times are specified? > > And what does it mean when one of them is, and the other one is not. > > Amareshwari Sriramadasu wrote: > Expression is valid between start time and end time, if both are > specified. If only start_time is specified, is valid from start_time to till > date. If only end_time is specified, is valid upto date specified, from any > time. If no start time, end time are specified, the expression is always > valid. Will update this in documentation. > > Rajat Khandelwal wrote: > So at a time more than one expression can be valid? What does that mean?
Yes. As described in the usecases of LENS-122, there can be more than one expression valid for expression column. And Lens should be able to figure out depending on candidate storages and candidate facts, which one should be used at run time. For example an expression cost = x + y (which can answered from a raw fact) vs cost = x1 + y1 (on an aggregate fact1) vs cost = x2+y2 (on a different fact, which is available in a particular storage). Though expression can be different, they would eventually yield same values i.e. (x + y) = (x1 + y1) = (x2+ y2). I will put up changes required on query rewriting in LENS-174 after this. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33669/#review82644 ----------------------------------------------------------- On May 6, 2015, 8:31 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33669/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 8:31 a.m.) > > > Review request for lens and Jaideep dhok. > > > Bugs: LENS-176 > https://issues.apache.org/jira/browse/LENS-176 > > > Repository: lens > > > Description > ------- > > - Added multiple expressions in XExprColumn > - Included optional start and end time for an expression in the expression > spec. > - Update examples with a measure and an attribute with multiple expressions, > and with start and end times specified. > - Update server tests with multiple expressions. > - Also fixed an existing issue with examples, where time format specified is > wrong. > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 24d0d64 > lens-cli/src/test/resources/sample-cube.xml 4908f85 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java > cccb888 > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > df4cf25 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > fa23b8e > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 8c8d578 > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java > 51db143 > lens-examples/src/main/resources/customer.xml e78dab2 > lens-examples/src/main/resources/product.xml 8093561 > lens-examples/src/main/resources/sales-cube.xml 951ace9 > lens-examples/src/main/resources/sample-cube.xml f24a8cc > lens-examples/src/main/resources/sample-db-only-dimension.xml 63a8bf8 > lens-examples/src/main/resources/sample-dimension.xml af4ab21 > lens-examples/src/main/resources/sample-dimension2.xml d1ac80d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 3cf7011 > > lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java > afb404b > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > a35a8ff > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 6f45e88 > > Diff: https://reviews.apache.org/r/33669/diff/ > > > Testing > ------- > > Created and Populated sample metastore, verified all expressions are fine, > thier start and end times. Example queries running fine. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.155s] > [INFO] Lens .............................................. SUCCESS [3.588s] > [INFO] Lens API .......................................... SUCCESS [19.294s] > [INFO] Lens API for server and extensions ................ SUCCESS [23.374s] > [INFO] Lens Cube ......................................... SUCCESS [3:30.498s] > [INFO] Lens DB storage ................................... SUCCESS [18.181s] > [INFO] Lens Query Library ................................ SUCCESS [15.484s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:52.665s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [32.639s] > [INFO] Lens Server ....................................... SUCCESS [5:18.173s] > [INFO] Lens client ....................................... SUCCESS [42.371s] > [INFO] Lens CLI .......................................... SUCCESS [3:32.471s] > [INFO] Lens Examples ..................................... SUCCESS [10.888s] > [INFO] Lens Distribution ................................. SUCCESS [12.703s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:17.143s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.706s] > [INFO] Lens Regression ................................... SUCCESS [8.220s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:43.522s > [INFO] Finished at: Wed May 06 08:25:54 UTC 2015 > [INFO] Final Memory: 109M/1376M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
