----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33838/ -----------------------------------------------------------
(Updated May 6, 2015, 5:18 p.m.) Review request for lens. Changes ------- Making weight as required field. The patch is not complete. Need mandatory check for -ve testcase scenario. Repository: lens Description ------- NPE when weight is not set in XFactTable object while creating fact table Diffs (updated) ----- lens-api/src/main/resources/cube-0.1.xsd 24d0d64 lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java PRE-CREATION lens-cli/src/test/resources/fact_without_weight.xml PRE-CREATION Diff: https://reviews.apache.org/r/33838/diff/ Testing ------- Yes. TestCase: mvn test -Dtest=TestLensFactCommandsWithMissingWeight#testFactCommands Thanks, Yash Sharma
