----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33838/#review82792 -----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java <https://reviews.apache.org/r/33838/#comment133610> Didnt this through an exception because of missing weight? lens-cli/src/test/resources/fact_without_weight.xml <https://reviews.apache.org/r/33838/#comment133611> Do you want to name the fact differently? The same name is used in TestLensFactCommands as well, it might conflict with fact created in other test. - Amareshwari Sriramadasu On May 6, 2015, 5:18 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33838/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 5:18 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > NPE when weight is not set in XFactTable object while creating fact table > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 24d0d64 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > PRE-CREATION > lens-cli/src/test/resources/fact_without_weight.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/33838/diff/ > > > Testing > ------- > > Yes. > TestCase: > mvn test -Dtest=TestLensFactCommandsWithMissingWeight#testFactCommands > > > Thanks, > > Yash Sharma > >
