-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review87554
-----------------------------------------------------------

Ship it!


Changes look fine.

Update CLI doc and ship.

- Amareshwari Sriramadasu


On June 11, 2015, 11:26 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 11:26 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-531
>     https://issues.apache.org/jira/browse/LENS-531
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> added command
> 
> 
> Diffs
> -----
> 
>   lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 719d10d94f638718d25c0b91f00abea75414ddf5 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDStoragePartitionCommand.java
>  208081db41b4a6bf75fb2c9bf95419b220861b00 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 
> d05d7a516d2c65b081464e84858a593ab8f0e1bf 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java
>  84ae6c3f4369f27ba893ceb29cf7d451014045a3 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
>  40380b7ff5d0d4b2ec3cbe5fcc0ec56ecdafcccf 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 
> 24992b9a58ab72c4f24321c60b6bfaf32733756e 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 1eb7ed677b023f3dc8f57f789b2c5f016dfa23dc 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LogicalTableCrudCommand.java
>  PRE-CREATION 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java
>  PRE-CREATION 
>   lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 
> 86099d3b65ef03be62825e1abcdf8ce88f2a1f60 
>   
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java 
> b599d6ed469354596e972ffafe75716eb5239378 
>   lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java 
> e5524bda29c55e7bb17ab081f8170716a297af18 
>   lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java 
> PRE-CREATION 
>   
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java 
> PRE-CREATION 
>   lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java 
> PRE-CREATION 
>   lens-cli/src/main/java/org/apache/lens/cli/table/XJoinChainTable.java 
> PRE-CREATION 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> ae39a2abe01d175c927fa2dcb80836c628e5c3ab 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
> 208eb78a1a4857976f974b728a1ba1a362e670b0 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> d5fd9995d7b1d74c61e27d5cb69ffc4cbff3ed4c 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> 7c8261928d9c3a734f75cd915439a623438e1e77 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
> 44f4f1f49894f235568aabc3de128879a233b35c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
>  890da4cbd365a6b01381a110f9888a5491b49727 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  64f6cd4bddeadfccc8ab992fcdf16151a29d3c24 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
>  e746ebbe5035fcc43563a5509f1dbf67d51980db 
>   pom.xml e2cbac531a9155cd7c7db19996cafe9f61c84eeb 
> 
> Diff: https://reviews.apache.org/r/34885/diff/
> 
> 
> Testing
> -------
> 
> lens-shell>cube show fields sales
> measures
> =============================
>   Name                       Display String              Description
>   -------------------------  --------------------------  -----------
>   line_item_discount_amount  Line item discount
>   line_item_product_price    Line item product price
>   line_item_quantity         Line item quantity
>   line_item_tax              Line item tax
>   max_line_item_discount     Maximum Line item discount
>   max_line_item_price        Maximum Line item price
>   rating                     Rating
>   store_cost                 Store Cost
>   store_sales                Store Sales
>   unit_sales                 Unit Sales
> 
> dim attributes
> =============================
>   Name                  Display String   Description
>   --------------------  ---------------  
> --------------------------------------------
>   customer_city_id
>   customer_city_name    Customer City    City name to which the customer 
> belongs
>   customer_id
>   delivery_city_id
>   delivery_city_name    Delivery City    City name to which the product was 
> delivered
>   delivery_time
>   order_id
>   order_line_number
>   order_time
>   product_id
>   production_city_id
>   production_city_name  Production City  City name in which the product was 
> produced
>   promotion_id
> 
> expr columns
> =============================
>   Name             Display String   Description  Expr Specs
>   ---------------  ---------------  -----------  
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>   profit           Profit                        always valid: store_sales - 
> store_cost
>   promotion_sales  Promotion sales               after 
> 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else 
> store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when 
> promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
> 
> 
> lens-shell>cube show joinchains sales
>   Name              Display String  Description  Destination Table  Path
>   ----------------  --------------  -----------  -----------------  
> -------------------------------------------------------
>   customer_details                               customer           
> sales.customer_id=customer.id
>   customer_city                                  city               
> sales.customer_city_id=city.id
>                                                                     
> sales.customer_id=customer.id->customer.city_id=city.id
>   product_details                                product            
> sales.product_id=product.id
>   production_city                                city               
> sales.production_city_id=city.id
>   delivery_city                                  city               
> sales.delivery_city_id=city.id
> 
> lens-shell>cube show fields sales --flattened
> measures
> =============================
>   Name                       Display String              Description
>   -------------------------  --------------------------  -----------
>   line_item_discount_amount  Line item discount
>   line_item_product_price    Line item product price
>   line_item_quantity         Line item quantity
>   line_item_tax              Line item tax
>   max_line_item_discount     Maximum Line item discount
>   max_line_item_price        Maximum Line item price
>   rating                     Rating
>   store_cost                 Store Cost
>   store_sales                Store Sales
>   unit_sales                 Unit Sales
> 
> dim attributes
> =============================
>   Name                                     Display String   Description
>   ---------------------------------------  ---------------  
> --------------------------------------------
>   customer_city_id
>   customer_city_name                       Customer City    City name to 
> which the customer belongs
>   customer_id
>   delivery_city_id
>   delivery_city_name                       Delivery City    City name to 
> which the product was delivered
>   delivery_time
>   order_id
>   order_line_number
>   order_time
>   product_id
>   production_city_id
>   production_city_name                     Production City  City name in 
> which the product was produced
>   promotion_id
>   customer_city.id
>   customer_city.name
>   customer_city.poi                                         Point of interests
>   customer_city.population
>   delivery_city.id
>   delivery_city.name
>   delivery_city.poi                                         Point of interests
>   delivery_city.population
>   production_city.id
>   production_city.name
>   production_city.poi                                       Point of interests
>   production_city.population
>   customer_details.age
>   customer_details.city_id
>   customer_details.customer_city_name      Customer City    City name to 
> which the customer belongs
>   customer_details.customer_credit_status
>   customer_details.gender
>   customer_details.id
>   customer_details.name
>   product_details.category
>   product_details.color
>   product_details.description
>   product_details.id
>   product_details.manufacturer
>   product_details.sku_number
>   product_details.weight
> 
> expr columns
> =============================
>   Name             Display String   Description  Expr Specs
>   ---------------  ---------------  -----------  
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>   isheavy                                        before 
> 2015-04-11T23:30:00.000+05:30: weight > 10, after 
> 2015-04-11T23:30:00.000+05:30: weight > 50
>   profit           Profit                        always valid: store_sales - 
> store_cost
>   promotion_sales  Promotion sales               after 
> 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else 
> store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when 
> promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
> 
> 
> lens-shell>dimension show fields customer
> dim attributes
> =============================
>   Name                    Display String  Description
>   ----------------------  --------------  
> ---------------------------------------
>   age
>   city_id
>   customer_city_name      Customer City   City name to which the customer 
> belongs
>   customer_credit_status
>   gender
>   id
>   name
> 
> 
> lens-shell>dimension show joinchains customer
>   Name           Display String  Description  Destination Table  Path
>   -------------  --------------  -----------  -----------------  
> ------------------------
>   customer_city                               city               
> customer.city_id=city.id
> 
> lens-shell>dimension show fields customer --flattened
> dim attributes
> =============================
>   Name                      Display String  Description
>   ------------------------  --------------  
> ---------------------------------------
>   age
>   city_id
>   customer_city_name        Customer City   City name to which the customer 
> belongs
>   customer_credit_status
>   gender
>   id
>   name
>   customer_city.id
>   customer_city.name
>   customer_city.poi                         Point of interests
>   customer_city.population
> 
> 
> lens-shell>
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to