-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34885/#review87353
-----------------------------------------------------------



lens-api/src/main/resources/cube-0.1.xsd
<https://reviews.apache.org/r/34885/#comment139687>

    I think text here was wrong earlier.
    
    Can be comma separated should be changed to space separated.



lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
<https://reviews.apache.org/r/34885/#comment139689>

    Can we add option to show only direct fields or all flattened fields, 
optionally?
    
    Because all flattened fields in some cases can be huge set. We have cubes 
which have 2K flattened fields.
    
    By default , we can show direct fields and --flattened fields can give full 
flattened list.
    
    What do you think?



lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java
<https://reviews.apache.org/r/34885/#comment139690>

    Remove commented code?



lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
<https://reviews.apache.org/r/34885/#comment139691>

    Should be moved to TestLensDimensionCommands?



lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
<https://reviews.apache.org/r/34885/#comment139692>

    API no more required?



lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
<https://reviews.apache.org/r/34885/#comment139693>

    API no more required?


- Amareshwari Sriramadasu


On June 9, 2015, 6:45 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34885/
> -----------------------------------------------------------
> 
> (Updated June 9, 2015, 6:45 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-531
>     https://issues.apache.org/jira/browse/LENS-531
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> added command
> 
> 
> Diffs
> -----
> 
>   lens-api/pom.xml adc464a0626151815214914b748514b2d8ebc8f2 
>   lens-api/src/main/resources/cube-0.1.xsd 
> 719d10d94f638718d25c0b91f00abea75414ddf5 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 
> d05d7a516d2c65b081464e84858a593ab8f0e1bf 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java 
> 6c4a1b5fc82a8fe4776919546d6f8c975ae0f514 
>   lens-cli/src/main/java/org/apache/lens/cli/skel/LensBanner.java 
> 86099d3b65ef03be62825e1abcdf8ce88f2a1f60 
>   
> lens-cli/src/main/java/org/apache/lens/cli/skel/LensHistoryFileProvider.java 
> b599d6ed469354596e972ffafe75716eb5239378 
>   lens-cli/src/main/java/org/apache/lens/cli/skel/LensPromptProvider.java 
> e5524bda29c55e7bb17ab081f8170716a297af18 
>   lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTable.java 
> PRE-CREATION 
>   
> lens-cli/src/main/java/org/apache/lens/cli/table/CollectionTableFactory.java 
> PRE-CREATION 
>   lens-cli/src/main/java/org/apache/lens/cli/table/XFlattenedColumnTable.java 
> PRE-CREATION 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> ae39a2abe01d175c927fa2dcb80836c628e5c3ab 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 
> 32a89ac98230d642738e1954b965c692c7235507 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> cd8bf166e11786ae8ec26df8d03dd381ef62d787 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
> 44f4f1f49894f235568aabc3de128879a233b35c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
>  890da4cbd365a6b01381a110f9888a5491b49727 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  64f6cd4bddeadfccc8ab992fcdf16151a29d3c24 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
>  e746ebbe5035fcc43563a5509f1dbf67d51980db 
>   pom.xml a9a3969f7eb217d7b12c52d64877854d97d6fc6a 
> 
> Diff: https://reviews.apache.org/r/34885/diff/
> 
> 
> Testing
> -------
> 
> lens-shell>show fields sales
> measures
> =============================
>   Name                       Display String              Description
>   -------------------------  --------------------------  -----------
>   line_item_discount_amount  Line item discount
>   line_item_product_price    Line item product price
>   line_item_quantity         Line item quantity
>   line_item_tax              Line item tax
>   max_line_item_discount     Maximum Line item discount
>   max_line_item_price        Maximum Line item price
>   rating                     Rating
>   store_cost                 Store Cost
>   store_sales                Store Sales
>   unit_sales                 Unit Sales
> 
> dim attributes
> =============================
>   Name                                     Display String   Description
>   ---------------------------------------  ---------------  
> --------------------------------------------
>   customer_city_id
>   customer_city_name                       Customer City    City name to 
> which the customer belongs
>   customer_id
>   delivery_city_id
>   delivery_city_name                       Delivery City    City name to 
> which the product was delivered
>   delivery_time
>   order_id
>   order_line_number
>   order_time
>   product_id
>   production_city_id
>   production_city_name                     Production City  City name in 
> which the product was produced
>   promotion_id
>   customer_city.id
>   customer_city.name
>   customer_city.poi                                         Point of interests
>   customer_city.population
>   delivery_city.id
>   delivery_city.name
>   delivery_city.poi                                         Point of interests
>   delivery_city.population
>   production_city.id
>   production_city.name
>   production_city.poi                                       Point of interests
>   production_city.population
>   customer_details.age
>   customer_details.city_id
>   customer_details.customer_city_name      Customer City    City name to 
> which the customer belongs
>   customer_details.customer_credit_status
>   customer_details.gender
>   customer_details.id
>   customer_details.name
>   product_details.category
>   product_details.color
>   product_details.description
>   product_details.id
>   product_details.manufacturer
>   product_details.sku_number
>   product_details.weight
> 
> expr columns
> =============================
>   Name             Display String   Description  Expr Specs
>   ---------------  ---------------  -----------  
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>   isheavy                                        before 
> 2015-04-11T23:30:00.000+05:30: weight > 10, after 
> 2015-04-11T23:30:00.000+05:30: weight > 50
>   profit           Profit                        always valid: store_sales - 
> store_cost
>   promotion_sales  Promotion sales               after 
> 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else 
> store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when 
> promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)
> 
> 
> lens-shell>show fields city
> dim attributes
> =============================
>   Name        Display String  Description
>   ----------  --------------  ------------------
>   id
>   name
>   poi                         Point of interests
>   population
> 
> 
> lens-shell>
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to