> On June 24, 2015, 11:27 a.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java, line 68 > > <https://reviews.apache.org/r/35821/diff/1/?file=991170#file991170line68> > > > > I feel this value is only internal and should not be returned to user > > through QueryCost > > Himanshu Gahlaut wrote: > It might help clients in doing relative comparison of cube queries via > result of estimate REST API. E.g. A User Interface might be interested in > showing queries which have cost between 0 and N in green color where as > queris which have cost > N in red color. Another user interface might choose > to use three colors instead of two and show queries with cost between 0 to M > in green, M to N in yellow, and > N in red.
Altrenative thought could be to abstract out clients and build a translation in lens presentation layer which can translate float cost returned by QueryCost interface into EstimateResult. EstimateResult could be composed of QueryCostType. QueryCostType could be an enum which can have three values LOW_COST, MEDIUM_COST, HIGH_COST. A translation within lens presentation layer would be more aligned with the thought mentioned by Amareshwari for keeping cost internal. - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35821/#review89149 ----------------------------------------------------------- On June 24, 2015, 9:37 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35821/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 9:37 a.m.) > > > Review request for lens. > > > Bugs: LENS-630 > https://issues.apache.org/jira/browse/LENS-630 > > > Repository: lens > > > Description > ------- > > Along with this, we can add a new field in QueryCost to return the query cost > calculated by the implementation. normalizedQueryCost could be one name for > that field. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/QueryCost.java > 1a37c20f408dac8d007e917a3b1107c96acb51f1 > lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java > 3c9268bc7f23687bd450cf01a44272df50a2df26 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > b7a3be72352cba201f7244822c08e59f298fc64c > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java > b0a04dfc59e2301aac336a97fe52024c4ebf76df > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java > PRE-CREATION > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java > bc1ec1c619f980d7a18314cb93d5438fc1d11321 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 8355f29df831fad25348b51bd22b0cc45c968f76 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > bda6572adfcc4834197608fa43f68dbaabb2d852 > > lens-server-api/src/main/java/org/apache/lens/server/api/priority/CostRangePriorityDecider.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryCostCalculator.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/priority/QueryPriorityDecider.java > 09a8ace5e4738b338ec241c83e297d071949a4bf > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > c398215f415c20b2bfcd3d743316f7300ac2baa1 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 09452226337bbacb12216efd43f15a2b957c0cf4 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9 > > Diff: https://reviews.apache.org/r/35821/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s] > [INFO] Lens .............................................. SUCCESS [3.277s] > [INFO] Lens API .......................................... SUCCESS [20.678s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.428s] > [INFO] Lens Cube ......................................... SUCCESS [3:37.068s] > [INFO] Lens DB storage ................................... SUCCESS [19.018s] > [INFO] Lens Query Library ................................ SUCCESS [15.157s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s] > [INFO] Lens Server ....................................... SUCCESS [5:45.727s] > [INFO] Lens client ....................................... SUCCESS [38.252s] > [INFO] Lens CLI .......................................... SUCCESS [2:35.316s] > [INFO] Lens Examples ..................................... SUCCESS [9.162s] > [INFO] Lens Distribution ................................. SUCCESS [8.978s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s] > [INFO] Lens Regression ................................... SUCCESS [10.724s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:22.407s > [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015 > [INFO] Final Memory: 173M/1360M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
