> On June 25, 2015, 12:31 p.m., Himanshu Gahlaut wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryCostCalculator.java, > > line 68 > > <https://reviews.apache.org/r/35821/diff/1/?file=991174#file991174line68> > > > > An instanceof check is normally a code smell. Could this be handled by > > polymorphism ? And if this can't be handled with polymorphism. Lets call > > out the reason for the same.
Called out. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35821/#review89325 ----------------------------------------------------------- On July 3, 2015, 5:07 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35821/ > ----------------------------------------------------------- > > (Updated July 3, 2015, 5:07 p.m.) > > > Review request for lens. > > > Bugs: LENS-630 > https://issues.apache.org/jira/browse/LENS-630 > > > Repository: lens > > > Description > ------- > > Along with this, we can add a new field in QueryCost to return the query cost > calculated by the implementation. normalizedQueryCost could be one name for > that field. > > > Diffs > ----- > > checkstyle/pom.xml 013e3913e87052456c7f4630b05a62e192c7845b > lens-api/pom.xml 66c038098aaa4a8943c6714ae01f883cf7cd3f71 > lens-cli/pom.xml d6dba49674af3414490c5598ffd0fb32ae62e349 > lens-client/pom.xml 6c1ae8fba383cbc233444cee91f0a2d339c6fa29 > lens-cube/pom.xml ea110afe88db60fc2a4a7adfd724da7e6d9a8812 > lens-dist/pom.xml ab9c87af6edd1ee1bf672b26af33f00e9fee6e72 > lens-dist/src/deb/control/postinst PRE-CREATION > lens-docker/lens-test/Dockerfile 46252f184e437e1ffd351bf1453ebdb11cc7866d > lens-docker/lens-test/lens-bootstrap.sh > bdc5e2cb7929b750df5d517a1c18c060e417de9a > lens-driver-hive/pom.xml e3d3aade38ad155bf4fd1f360525c0b077c52e90 > lens-driver-jdbc/pom.xml 0515941b4ec6f626a68b08bd47fd117ee6f85b34 > lens-examples/pom.xml 1406e98ebc2baee666489ec573157b9db8146e50 > lens-ml-dist/pom.xml 0ed11301d67329ff172cd27b62492c84b0f7df8e > lens-ml-lib/pom.xml f8f2b8537753bb7903207e0ac6f3448916420c1c > lens-query-lib/pom.xml 454df63f57ce8942159545f79199741e894c5891 > lens-regression/pom.xml dd97637a0d515ea551263c7db7a0a353603adb34 > lens-server-api/pom.xml 26ac76373f3c5c56d144d7f9baec43819c6efce7 > lens-server/pom.xml f9a16cbb3e73993bd8a7c4ced97281847b6eb247 > lens-storage-db/pom.xml f8752224af2233317f4172669668b89cf2273315 > pom.xml ee540513c5353cf586b15208af01bcd36d4fd9e4 > tools/conf-pseudo-distr/server/hivedriver-site.xml > 67daeeba33d7008c2848b4e15bd1da31f2be2832 > tools/scripts/generate-site-public.sh > 0f2e45c8bfbf92dd3134ec1891be23fb50cc3256 > > Diff: https://reviews.apache.org/r/35821/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.387s] > [INFO] Lens .............................................. SUCCESS [3.277s] > [INFO] Lens API .......................................... SUCCESS [20.678s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.428s] > [INFO] Lens Cube ......................................... SUCCESS [3:37.068s] > [INFO] Lens DB storage ................................... SUCCESS [19.018s] > [INFO] Lens Query Library ................................ SUCCESS [15.157s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:56.027s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [36.331s] > [INFO] Lens Server ....................................... SUCCESS [5:45.727s] > [INFO] Lens client ....................................... SUCCESS [38.252s] > [INFO] Lens CLI .......................................... SUCCESS [2:35.316s] > [INFO] Lens Examples ..................................... SUCCESS [9.162s] > [INFO] Lens Distribution ................................. SUCCESS [8.978s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:21.324s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.613s] > [INFO] Lens Regression ................................... SUCCESS [10.724s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:22.407s > [INFO] Finished at: Wed Jun 24 09:32:15 UTC 2015 > [INFO] Final Memory: 173M/1360M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
