> On July 4, 2015, 2:01 p.m., Rajat Khandelwal wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, > > line 21 > > <https://reviews.apache.org/r/36178/diff/1/?file=999115#file999115line21> > > > > There are other files too that need file path. query command needs for > > result storing. metastore commands have create command which needs file > > name. etc.
Thanks. Have added changes for the ones I could spot. Do let me know in case i missed any commands. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36178/#review90385 ----------------------------------------------------------- On July 4, 2015, 6:25 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36178/ > ----------------------------------------------------------- > > (Updated July 4, 2015, 6:25 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Added changes for file name suggestions on Tab. Changed String file paths to > File. > > > https://issues.apache.org/jira/browse/LENS-634 > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 74b4e91 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > 8b4face > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 6ba702f > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > de022c1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 6a93393 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > bdb9c38 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > c48fabd > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 928120a > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 7503221 > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 73661e1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > b6f96e6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > a22862e > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > a87d0b7 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 13bfbd2 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 73f3a78 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 46e28a9 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 3a04ec6 > > Diff: https://reviews.apache.org/r/36178/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.076 > s] > [INFO] Lens ............................................... SUCCESS [ 2.687 > s] > [INFO] Lens API ........................................... SUCCESS [ 19.435 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 21.664 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:15 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 20.368 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 16.793 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:33 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.684 > s] > [INFO] Lens Server ........................................ SUCCESS [05:16 > min] > [INFO] Lens client ........................................ SUCCESS [ 39.897 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:14 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 9.767 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.144 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:16 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.218 > s] > [INFO] Lens Regression .................................... SUCCESS [ 11.612 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:46 min > [INFO] Finished at: 2015-07-04T16:52:09+05:30 > [INFO] Final Memory: 125M/401M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
