> On July 17, 2015, 5:13 p.m., Rajat Khandelwal wrote: > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, > > line 220 > > <https://reviews.apache.org/r/36178/diff/3/?file=1012781#file1012781line220> > > > > This check is not required. path.getPath will never be null.
The check is also responsible for returning a proper message where the plan is stored rather than returning the plan for printing on console, so looks legit - "Saved to " + <PATH> > On July 17, 2015, 5:13 p.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line > > 194 > > <https://reviews.apache.org/r/36178/diff/3/?file=1012791#file1012791line194> > > > > What is the behaviour of cli on optional File arguments? What gets > > passed to the method? `null` or `new File("")`? If it's `null`, we'll have > > to modify all test cases (and possibly code) to behave proper for that. Oh gosh, this is a huge bug in here. @NonNull makes this field sort-of required field. It adds a null check at the beginning of the method and blows up with NPE if not provided. I have no clue how I missed this ! This means that we will have to take care of the null checks ourselves in the code. Will work over it in the weekend and patch back. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36178/#review92101 ----------------------------------------------------------- On July 17, 2015, 5:08 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36178/ > ----------------------------------------------------------- > > (Updated July 17, 2015, 5:08 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Added changes for file name suggestions on Tab. Changed String file paths to > File. > > > https://issues.apache.org/jira/browse/LENS-634 > > > Diffs > ----- > > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > 74b4e91 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > 9cb7d69 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > 8b4face > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 6ba702f > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > de022c1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 6a93393 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > bdb9c38 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > c48fabd > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 928120a > > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > a479c14 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 7503221 > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 73661e1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > b6f96e6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > a22862e > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > a87d0b7 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 13bfbd2 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 73f3a78 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 46e28a9 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 3a04ec6 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > a5033fe > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > 92687c3 > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 715347f > src/site/apt/user/cli.apt 353c171 > > Diff: https://reviews.apache.org/r/36178/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.135 > s] > [INFO] Lens ............................................... SUCCESS [ 2.813 > s] > [INFO] Lens API ........................................... SUCCESS [ 20.590 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 22.734 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:42 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 19.573 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 15.858 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:37 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.645 > s] > [INFO] Lens Server ........................................ SUCCESS [04:54 > min] > [INFO] Lens client ........................................ SUCCESS [ 36.606 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:11 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.632 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 7.609 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:21 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.390 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 17:58 min > [INFO] Finished at: 2015-07-17T22:32:49+05:30 > [INFO] Final Memory: 126M/393M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
