-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/
-----------------------------------------------------------
(Updated July 8, 2015, 4:50 p.m.)
Review request for lens.
Bugs: LENS-650
https://issues.apache.org/jira/browse/LENS-650
Repository: lens
Description
-------
By separation of concerns, pre submit hook needs to be separate from user
config loader. The code was made a part of user config loader because the need
originated as a gap in user config loader. But the solution could have been
separate. Creating this jira to address this issue.
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
b7a3be72352cba201f7244822c08e59f298fc64c
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
8355f29df831fad25348b51bd22b0cc45c968f76
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
c144fd8799a96491d3aac7f7e7fcc6391b726985
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
bda6572adfcc4834197608fa43f68dbaabb2d852
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
be34164dd49b734b94fc2c121130613555402d50
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
ad27d78e1839fa60df8f2429901b77221be71653
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DefaultPreDriverLaunchHook.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
3dc4e734eac979d7bd8f94ee3cb4eb986d4d5081
lens-server-api/src/main/java/org/apache/lens/server/api/driver/PreDriverLaunchHook.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java
93e11a25cf2934e8665f8b99f98d9ddb4fca0020
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
4b80918f3d1cf9f3f683fbdb4d1a89bc55e4b0f9
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockPreLaunchHook.java
PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java
f6ef0d46a081db0d5befd27ba88051b946e38429
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
429b26283afbd15a357b1529c2ca6767cca83691
lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java
ce0d1125c51423caed6e4deb3967dd54af91df1e
lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java
5813ac0dc86bc83ba874af19a07d95dd5c932141
lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java
009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java
0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
Diff: https://reviews.apache.org/r/36297/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.874s]
[INFO] Lens .............................................. SUCCESS [2.753s]
[INFO] Lens API .......................................... SUCCESS [18.422s]
[INFO] Lens API for server and extensions ................ SUCCESS [18.265s]
[INFO] Lens Cube ......................................... SUCCESS [4:13.248s]
[INFO] Lens DB storage ................................... SUCCESS [39.612s]
[INFO] Lens Query Library ................................ SUCCESS [37.755s]
[INFO] Lens Hive Driver .................................. SUCCESS [3:03.308s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [35.056s]
[INFO] Lens Server ....................................... SUCCESS [5:30.772s]
[INFO] Lens client ....................................... SUCCESS [39.233s]
[INFO] Lens CLI .......................................... SUCCESS [2:48.013s]
[INFO] Lens Examples ..................................... SUCCESS [9.927s]
[INFO] Lens Distribution ................................. SUCCESS [8.531s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:28.750s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.839s]
[INFO] Lens Regression ................................... SUCCESS [12.545s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:50.747s
[INFO] Finished at: Wed Jul 08 11:19:26 UTC 2015
[INFO] Final Memory: 187M/1793M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
