-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36297/
-----------------------------------------------------------
(Updated July 16, 2015, 7:15 p.m.)
Review request for lens.
Bugs: LENS-650
https://issues.apache.org/jira/browse/LENS-650
Repository: lens
Description
-------
By separation of concerns, pre submit hook needs to be separate from user
config loader. The code was made a part of user config loader because the need
originated as a gap in user config loader. But the solution could have been
separate. Creating this jira to address this issue.
Diffs (updated)
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java
e87ed23429d3172db86c17e4ec5e37e2e903374b
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
67a4667d6443d5363f311dadfe30bb4e73ee4217
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
c144fd8799a96491d3aac7f7e7fcc6391b726985
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
e048a78a08b29045f86e69f0180ab04f50705315
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java
5abd040c46cc6a3b81c89ef9ccdfc70dc09c2fae
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java
a6c97aeee50e730888c366d12b41c54d75eaf317
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
eab42d095ced23b9fd5b1fb854043d9668307883
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
b56c67ce6909a11b1cdec9f52427683f0b11dd41
lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/user/UserConfigLoader.java
93e11a25cf2934e8665f8b99f98d9ddb4fca0020
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
b52b08ad78a4c74c61376fb3c6bc6284f38b0de9
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
PRE-CREATION
lens-server-api/src/test/java/org/apache/lens/server/api/user/MockUserConfigLoader.java
f6ef0d46a081db0d5befd27ba88051b946e38429
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
35112367b1b40309c04e6748f7ae69ceac959a28
lens-server/src/main/java/org/apache/lens/server/user/DatabaseUserConfigLoader.java
ce0d1125c51423caed6e4deb3967dd54af91df1e
lens-server/src/main/java/org/apache/lens/server/user/FixedUserConfigLoader.java
5813ac0dc86bc83ba874af19a07d95dd5c932141
lens-server/src/main/java/org/apache/lens/server/user/PropertyBasedUserConfigLoader.java
009e34a25aaf6f3bd32ba1a4ae0f2a486a7ff995
lens-server/src/test/java/org/apache/lens/server/user/FooBarConfigLoader.java
0a319efe9ab84b6d62f87cf6cd4837ece75dae1b
Diff: https://reviews.apache.org/r/36297/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.854s]
[INFO] Lens .............................................. SUCCESS [2.786s]
[INFO] Lens API .......................................... SUCCESS [19.928s]
[INFO] Lens API for server and extensions ................ SUCCESS [16.773s]
[INFO] Lens Cube ......................................... SUCCESS [4:12.475s]
[INFO] Lens DB storage ................................... SUCCESS [18.426s]
[INFO] Lens Query Library ................................ SUCCESS [13.940s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:45.497s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.123s]
[INFO] Lens Server ....................................... SUCCESS [5:36.222s]
[INFO] Lens client ....................................... SUCCESS [34.486s]
[INFO] Lens CLI .......................................... SUCCESS [2:34.816s]
[INFO] Lens Examples ..................................... SUCCESS [8.202s]
[INFO] Lens Distribution ................................. SUCCESS [8.005s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:18.986s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.963s]
[INFO] Lens Regression ................................... SUCCESS [11.062s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:22.384s
[INFO] Finished at: Thu Jul 16 13:41:39 UTC 2015
[INFO] Final Memory: 181M/1709M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
