----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35590/#review92233 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java (line 197) <https://reviews.apache.org/r/35590/#comment146284> The same signature of the function is being added to all services. We can probably extract out an interface and extend the services from it. Then we'll not need health check classes for each service. The interface can be called `HealthCheckable`. This would be a short and sweet solution. However, we can take this as an opportunity to refactor and make a `LensService` interface. The current `LensService` class would either be called `LensServiceImpl` or its methods will move to someplace else causing us to use composition over inheritence. Of course, if the change is too big, we can leave the latter part and only do the renaming. - Rajat Khandelwal On July 19, 2015, 2:24 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35590/ > ----------------------------------------------------------- > > (Updated July 19, 2015, 2:24 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens service health status. > > https://issues.apache.org/jira/browse/LENS-477 > > Initial patch for LENS-477. > We should list all other API/Endpoints etc that should be considered for > health checks. > > Current checks implemented- > curl http://localhost:9999/admin/healthcheck > {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}} > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/health/HealthStatus.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java > 74cc00c > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 71128b7 > lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java > 5855ac6 > lens-server/src/main/java/org/apache/lens/server/LensService.java ae9af6a > > lens-server/src/main/java/org/apache/lens/server/healthcheck/CubeMetastoreServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/EventServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/HealthCheckUtil.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/HiveSessionServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/MetricsServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QueryExecutionServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QuerySchedulerServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/healthcheck/QuotaServiceImplHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > c5e1c14 > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 39f9f52 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 3511236 > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > 89cfe71 > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 32feeb9 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 3a8fc95 > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > a84fcd3 > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35590/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 > s] > [INFO] Lens ............................................... SUCCESS [ 3.994 > s] > [INFO] Lens API ........................................... SUCCESS [ 20.033 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 22.663 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:51 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 19.836 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 15.746 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:44 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.651 > s] > [INFO] Lens Server ........................................ SUCCESS [05:55 > min] > [INFO] Lens client ........................................ SUCCESS [ 38.404 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:13 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 12.174 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.385 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:22 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.994 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.776 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:24 min > [INFO] Finished at: 2015-07-19T13:30:22+05:30 > [INFO] Final Memory: 130M/408M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
