----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35590/#review92871 -----------------------------------------------------------
Ship it! Other changes look fine. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (lines 2499 - 2505) <https://reviews.apache.org/r/35590/#comment147117> Seems a merge issue. This was moved to UtilityMethods. - Amareshwari Sriramadasu On July 23, 2015, 5:40 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35590/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 5:40 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Lens service health status. > > https://issues.apache.org/jira/browse/LENS-477 > > Initial patch for LENS-477. > We should list all other API/Endpoints etc that should be considered for > health checks. > > Current checks implemented- > curl http://localhost:9999/admin/healthcheck > {"admin-status":{"healthy":true},"metastore":{"healthy":true},"queryapi":{"healthy":true}} > > > Diffs > ----- > > lens-server-api/src/main/java/org/apache/lens/server/api/LensService.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java > 74cc00c > > lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthCheckable.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/health/HealthStatus.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > bd31f82 > > lens-server-api/src/main/java/org/apache/lens/server/api/metrics/MetricsService.java > 72fe455 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java > 2c6f912 > lens-server/src/main/java/org/apache/lens/server/LensService.java 0e564a9 > lens-server/src/main/java/org/apache/lens/server/LensServices.java 1bcc5944 > > lens-server/src/main/java/org/apache/lens/server/healthcheck/LensServiceHealthCheck.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 646de8c > > lens-server/src/main/java/org/apache/lens/server/metrics/MetricsServiceImpl.java > 2455232 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 5e0f24a > > lens-server/src/main/java/org/apache/lens/server/quota/QuotaServiceImpl.java > 89cfe71 > > lens-server/src/main/java/org/apache/lens/server/scheduler/QuerySchedulerServiceImpl.java > 32feeb9 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 3a8fc95 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 0635e95 > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > 697e867 > > lens-server/src/test/java/org/apache/lens/server/healthcheck/TestHealthChecks.java > PRE-CREATION > src/site/apt/user/cli.apt 63f2b3f > > Diff: https://reviews.apache.org/r/35590/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.755 > s] > [INFO] Lens ............................................... SUCCESS [ 5.646 > s] > [INFO] Lens API ........................................... SUCCESS [ 22.286 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 20.510 > s] > [INFO] Lens Cube .......................................... SUCCESS [03:34 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 19.073 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 14.134 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:29 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.798 > s] > [INFO] Lens Server ........................................ SUCCESS [05:46 > min] > [INFO] Lens client ........................................ SUCCESS [ 39.626 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:09 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 9.641 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 7.716 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:21 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.037 > s] > [INFO] Lens Regression .................................... SUCCESS [ 12.356 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 18:34 min > [INFO] Finished at: 2015-07-23T22:56:31+05:30 > [INFO] Final Memory: 131M/390M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
