> On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote: > > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java, > > line 73 > > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021879#file1021879line73> > > > > Is there supposed to be a space somewhere?
No. No space in path. > On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote: > > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java, > > line 110 > > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021879#file1021879line110> > > > > `file:/a/b/c` will also match, right? Yes it will match file:/ and try to check if its present in the URI_SCHEME_MAPPING map. Anything present in the URI_SCHEME_MAPPING map would be a candidate for special handling. Currently the map only has entry for hdfs, s3 & s3n. > On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote: > > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java, line > > 161 > > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021880#file1021880line161> > > > > Please add a third argument to the assert method. Saying that `ith` > > didn't match. Done. > On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote: > > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java, > > lines 105-107 > > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021880#file1021880line105> > > > > This block is not needed. Exception thrown will automatically fail the > > test. Done. > On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote: > > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java, > > lines 129-131 > > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021880#file1021880line129> > > > > Redundant block Not revoved - for checked exception. - Yash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36178/#review93247 ----------------------------------------------------------- On July 28, 2015, 8:04 a.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36178/ > ----------------------------------------------------------- > > (Updated July 28, 2015, 8:04 a.m.) > > > Review request for lens. > > > Bugs: LENS-634 > https://issues.apache.org/jira/browse/LENS-634 > > > Repository: lens > > > Description > ------- > > Added changes for file name suggestions on Tab. Changed String file paths to > File. > > > https://issues.apache.org/jira/browse/LENS-634 > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java > PRE-CREATION > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java > PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > bdfae24 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > 9cb7d69 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > c059f30 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 6ba702f > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > de022c1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 5fd80a1 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 5493dba > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > c48fabd > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 928120a > > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > c505680 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > ae04b3f > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 73661e1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > b6f96e6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > a22862e > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 56e962d > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > fa342c8 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 73f3a78 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 319077a > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 3a04ec6 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 1316257 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > 92687c3 > src/site/apt/user/cli.apt a28d8a4 > > Diff: https://reviews.apache.org/r/36178/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.025 > s] > [INFO] Lens ............................................... SUCCESS [ 3.273 > s] > [INFO] Lens API ........................................... SUCCESS [ 22.153 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 21.811 > s] > [INFO] Lens Cube .......................................... SUCCESS [05:38 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 21.700 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 18.521 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:38 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.994 > s] > [INFO] Lens Server ........................................ SUCCESS [05:12 > min] > [INFO] Lens client ........................................ SUCCESS [ 35.757 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:07 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 9.207 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 8.026 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:32 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.085 > s] > [INFO] Lens Regression .................................... SUCCESS [ 11.609 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 20:23 min > [INFO] Finished at: 2015-07-28T13:28:25+05:30 > [INFO] Final Memory: 130M/396M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
