----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36178/#review93429 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (line 104) <https://reviews.apache.org/r/36178/#comment147793> add jar is supposed to be happening on server side. So the file is not expected to be present on client machine. Let's not call `getValidPath` here. - Rajat Khandelwal On July 29, 2015, 2:51 p.m., Yash Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36178/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 2:51 p.m.) > > > Review request for lens. > > > Bugs: LENS-634 > https://issues.apache.org/jira/browse/LENS-634 > > > Repository: lens > > > Description > ------- > > Added changes for file name suggestions on Tab. Changed String file paths to > File. > > > https://issues.apache.org/jira/browse/LENS-634 > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java > PRE-CREATION > lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java > PRE-CREATION > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java > bdfae24 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java > 9cb7d69 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java > c059f30 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java > 6ba702f > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java > de022c1 > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java > 5fd80a1 > lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java > 5493dba > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > c48fabd > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java > 928120a > > lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java > c505680 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > ae04b3f > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 73661e1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > b6f96e6 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > a22862e > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 56e962d > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > fa342c8 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 73f3a78 > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 319077a > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 3a04ec6 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > ae6d682 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > 92687c3 > src/site/apt/user/cli.apt a28d8a4 > > Diff: https://reviews.apache.org/r/36178/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.073 > s] > [INFO] Lens ............................................... SUCCESS [ 2.919 > s] > [INFO] Lens API ........................................... SUCCESS [ 24.629 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 24.005 > s] > [INFO] Lens Cube .......................................... SUCCESS [06:03 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 21.249 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 16.129 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:42 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.475 > s] > [INFO] Lens Server ........................................ SUCCESS [05:53 > min] > [INFO] Lens client ........................................ SUCCESS [ 43.273 > s] > [INFO] Lens CLI ........................................... SUCCESS [02:24 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 10.744 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 7.569 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:39 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.106 > s] > [INFO] Lens Regression .................................... SUCCESS [ 11.772 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 22:10 min > [INFO] Finished at: 2015-07-29T14:38:55+05:30 > [INFO] Final Memory: 130M/400M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Yash Sharma > >
