----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36934/#review93564 -----------------------------------------------------------
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java (lines 63 - 70) <https://reviews.apache.org/r/36934/#comment147945> Can we convert types of these to `Integer`, `Long` etc instead of `int`, `long`? That will ensure that unnecessary transfer of 4 bytes per field will not happen if the values are `unknown`. Then we can do away with using `-1` as a placeholder for `unknown`. using `null` would suffice. - Rajat Khandelwal On July 30, 2015, 2:57 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36934/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 2:57 p.m.) > > > Review request for lens, Jaideep dhok and Pranav Agarwal. > > > Bugs: LENS-651 > https://issues.apache.org/jira/browse/LENS-651 > > > Repository: lens > > > Description > ------- > > Added file size in the /resultset api response in case of persistent resultset > > > Diffs > ----- > > > incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java > 70dac08 > > incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java > 3d1f20a > > incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java > 82b0568 > > incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java > f80cdd8 > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java > 48e020f > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java > 2c48209 > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java > 270f0f0 > > incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java > cc6d918 > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java > af354cc > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java > 13f069f > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 0c78e01 > > incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java > 1d2e89b > > incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > ea24336 > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java > 80eb697 > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 1904350 > > incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 1316257 > > Diff: https://reviews.apache.org/r/36934/diff/ > > > Testing > ------- > > Yes. > > > Thanks, > > Deepak Barr > >
