-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36934/
-----------------------------------------------------------
(Updated Aug. 8, 2015, 6:03 a.m.)
Review request for lens, Jaideep dhok and Pranav Agarwal.
Changes
-------
1. convert types of numRows and fileSize to Integer, Long from int, long.
2. Moved fileSize to PersistentResultSet
3. Included filesize assertion in unit test
4. From lens-cli, numRows appear only when its available.
Bugs: LENS-651
https://issues.apache.org/jira/browse/LENS-651
Repository: lens
Description
-------
Added file size in the /resultset api response in case of persistent resultset
Diffs (updated)
-----
incubator-lens/lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java
70dac08
incubator-lens/lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
88facda
incubator-lens/lens-driver-es/src/main/java/org/apache/lens/driver/es/client/ESResultSet.java
4ba2321
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java
3d1f20a
incubator-lens/lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java
82b0568
incubator-lens/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java
f80cdd8
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java
48e020f
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/HadoopFileFormatter.java
2c48209
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/WrappedFileFormatter.java
aa66b7b
incubator-lens/lens-query-lib/src/main/java/org/apache/lens/lib/query/ZipFileFormatter.java
cc6d918
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java
af354cc
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java
13f069f
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
0c78e01
incubator-lens/lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryOutputFormatter.java
1d2e89b
incubator-lens/lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
17dc99b
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java
80eb697
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java
e392e34
incubator-lens/lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
2983db4
incubator-lens/lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
beaa247
Diff: https://reviews.apache.org/r/36934/diff/
Testing
-------
Yes.
Thanks,
Deepak Barr