Re: Review Request 36984: LENS-700: Execute Async shall do semantic validation, rewrite, select driver and estimate cost before accepting a query for asynchronous execution

[Amareshwari Sriramadasu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36984/#review93868
-----------------------------------------------------------



lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
 
<https://reviews.apache.org/r/36984/#comment148284>

    Query failure for launching can happen even now - though rewrite and select 
does not happen. Earlier test was depending on non existing table to trigger 
launch failure. Now we can have launch failures because underlying driver is 
down.
    
    Can we try putting the test back with launch failures?
    
    Here is an approach I could think :
    
    FailingDriver {
    estimate () {
    if (query.contains("failing")) {
     // accept by returning 0 cost.
    } else {
    // throw exception
    }
    
    executeAsync() {
    // throw exception
    }



lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
(line 220)
<https://reviews.apache.org/r/36984/#comment148285>

    Can we add testLaunchFail() with launch failures?


- Amareshwari Sriramadasu


On July 31, 2015, 11:35 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36984/
> -----------------------------------------------------------
> 
> (Updated July 31, 2015, 11:35 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-700: Execute Async shall do semantic validation, rewrite, select driver 
> and estimate cost before accepting a query for asynchronous execution
> 
> 
> Diffs
> -----
> 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5 
>   lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 
> 28ff92059b0c3040dcb54811c39a59bf684c0f6b 
>   lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 
> b5235ad5a799cb54c27bb2449478c4e9ef593bc0 
>   
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
> 80e29ba114dbde97ab932027c7946315cdafb9c6 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  91e908139ca556d8611dff9eb109d9620a513352 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
>  f1461bc2bd2c89836c26fd3445988009b25c6b18 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 4b9962a9cda22002cdc4826ebce3db4c77216223 
> 
> Diff: https://reviews.apache.org/r/36984/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [4.881s]
> [INFO] Lens .............................................. SUCCESS [4.588s]
> [INFO] Lens API .......................................... SUCCESS [44.023s]
> [INFO] Lens API for server and extensions ................ SUCCESS [32.745s]
> [INFO] Lens Cube ......................................... SUCCESS [7:39.032s]
> [INFO] Lens DB storage ................................... SUCCESS [1:41.287s]
> [INFO] Lens Query Library ................................ SUCCESS [20.810s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:40.758s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [48.890s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [26.143s]
> [INFO] Lens Server ....................................... SUCCESS 
> [13:20.335s]
> [INFO] Lens client ....................................... SUCCESS [53.538s]
> [INFO] Lens CLI .......................................... SUCCESS [4:31.457s]
> [INFO] Lens Examples ..................................... SUCCESS [16.966s]
> [INFO] Lens Distribution ................................. SUCCESS [20.166s]
> [INFO] Lens ML Lib ....................................... SUCCESS [2:20.115s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [5.550s]
> [INFO] Lens Regression ................................... SUCCESS [17.419s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 38:09.849s
> [INFO] Finished at: Fri Jul 31 17:03:15 IST 2015
> [INFO] Final Memory: 127M/412M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>