> On Aug. 3, 2015, 1:34 p.m., Rajat Khandelwal wrote: > > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java, line > > 178 > > <https://reviews.apache.org/r/36984/diff/1/?file=1026086#file1026086line178> > > > > Is this change needed? > > Himanshu Gahlaut wrote: > Yes
Why? - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36984/#review93874 ----------------------------------------------------------- On Aug. 4, 2015, 3:04 a.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36984/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 3:04 a.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > LENS-700: Addressed code review comments > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > ae6d6822f6b116f07dd9a204bdf5a7c8ee7671d5 > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > 28ff92059b0c3040dcb54811c39a59bf684c0f6b > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > b5235ad5a799cb54c27bb2449478c4e9ef593bc0 > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 80e29ba114dbde97ab932027c7946315cdafb9c6 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 91e908139ca556d8611dff9eb109d9620a513352 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > f1461bc2bd2c89836c26fd3445988009b25c6b18 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 4b9962a9cda22002cdc4826ebce3db4c77216223 > lens-server/src/test/resources/lens-site.xml > bd9382820d59ecdc075d1f9b7258e31f899ca6d5 > > Diff: https://reviews.apache.org/r/36984/diff/ > > > Testing > ------- > > Will test again after rebasing with master branch. > > > Thanks, > > Himanshu Gahlaut > >
