Ben wrote: > 1) The search() method in rcube_contacts.inc; I think while testing this > patch, I think I found a glitch in it. If you have a contact in your > address book > and you delete it by mistake, then try to add the same contact again, it > will see it as a > duplicate and won't let you add it. This is because the search() method > searches all contacts, even those with the `del` flag set. Should I try to > fix this, or just file a bug report? Does anybody more familiar with the > source know if it will break anything if I make it only search records not > deleted? Or maybe when instructed to add a duplicate contact, Roundcube > should simply turn off the 'del' flag if it's set?
as far as i know you can simply fix it and post a patch to the webinterface (trac). > 4) As I'm monolinguistic, I've only added the message for it > ($messages['alwaysshow']) to the en_US locale, so it won't display properly > if your locale is different. Sorry. i think this is okay - let the translators do their work ;) cheers, raoul bhatia -- ____________________________________________________________________ DI (FH) Raoul Bhatia M.Sc. email. [EMAIL PROTECTED] Technischer Leiter IPAX - Aloy Bhatia Hava OEG web. http://www.ipax.at Barawitzkagasse 10/2/2/11 email. [EMAIL PROTECTED] 1190 Wien tel. +43 1 3670030 FN 277995t HG Wien fax. +43 1 3670030 15 ____________________________________________________________________ _______________________________________________ List info: http://lists.roundcube.net/dev/
