David, be reasonable. I think Alec and Thomas have very sensible objections to your commits.
As an example: https://github.com/roundcube/roundcubemail/commit/454f7a93790375e5076324b4733bde15eaf86ab0 That is a single commit removing 1 line, with a comment of 'yup, makes sense'. What makes sense? I feel im missing some part of a discussion just reading that commit history. You feel you're not being properly recognised if you submit a PR with sensible commits and sensible commit comments? This isnt about commit counting but about substance. The substance is great, but it is being diluted in an avalanche of commits that are all trivial and unclear. I would much rather see a PR with 1 commit that contain a group of code cleanups, with a commit comment like: "Code cleanup by David Deutsch". Anyways, i really hope you'll re-commit your PRs because this unfortunate argument seems solvable. Cor _______________________________________________ Roundcube Development discussion mailing list [email protected] http://lists.roundcube.net/mailman/listinfo/dev
