On Mon, Dec 30, 2013 at 6:50 AM, Cedric BAIL <cedric.b...@free.fr> wrote:
> Hello,
>
> On Mon, Dec 30, 2013 at 5:06 PM, Juan Zhao <juan.j.z...@linux.intel.com> 
> wrote:
>>     In current elementary code, we can find that elementary will add an 
>> frame for wayland backend. While this is not required for all conditions. 
>> For example, in mobile environment, most of the windows will be 
>> fullscreened, or frameless.
>>
>>     Because other than the desktop environment, it's better to add a frame 
>> on demand. I'm thinking of one way to remove this default setting, and 
>> leverage the frame setting to the application itself, the reference code is 
>> listed below, and what's your suggestions for this frame setting?
>>
>> diff --git a/src/lib/elm_win.c b/src/lib/elm_win.c
>> index 9d23d1a..ca39bdb 100644
>> --- a/src/lib/elm_win.c
>> +++ b/src/lib/elm_win.c
>> @@ -3144,10 +3144,6 @@ _win_constructor(Eo *obj, void *_pd, va_list *list)
>>       {
>>          TRAP(sd, fullscreen_set, 1);
>>       }
>> -   else if ((type != ELM_WIN_INLINED_IMAGE) &&
>> -            (ENGINE_COMPARE(ELM_WAYLAND_SHM) ||
>> -             ENGINE_COMPARE(ELM_WAYLAND_EGL)))
>> -     _elm_win_frame_add(sd, "default");
>>
>>         cc tizen-dev maillist, because tizen mobile and ivi are using the 
>> same code base.
>
> Don't we have a theme to solve that issue ? I don't think putting
> things like that in the application is a good idea at all. It lock
> them down to work only on one specific device and when you want to
> expand to other device/use case, you end up with a mess to maintain.

Yes, we do. Just removing the theme group responsible for the frame is
enough to make sure that no frame will be drawn.

-- 
Rafael Antognolli
_______________________________________________
Dev mailing list
Dev@lists.tizen.org
https://lists.tizen.org/listinfo/dev

Reply via email to