Hi Patrick, Yes, the code was merged, maybe little bit too early, but except Jacek (he's made proper review) who is working with you on DBus, no one is using this code now except experimental code that Jacek Bukarewicz wrote. It will evolve anyway, we will change it (although I don't believe that reverting it is a good idea as there was no Cynara release), if you have any proposal for changes, feel free to write about them and/or let us know with a patch, your comments are valuable for the project.
What I think caused this situation is the fact that currently gerrit only adds Bumjin and Casey as reviewers and we tend to forget adding other reviewers. Bumjin and Casey are taking care of security in Tizen as a whole and they should not spend even 30 mins daily on assigning proper reviewers to patches. I think this is the topic that deserves better discussion. We have a system that is not configured properly (there was the idea of "sub-domains" but where did it go?). BRs, Tomasz Świerczek Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 95 59 Cell +48 503 135 021 [email protected] -----Original Message----- From: Dev [mailto:[email protected]] On Behalf Of Patrick Ohly Sent: Monday, August 18, 2014 4:57 PM To: Lukasz Wojciechowski Cc: [email protected] Subject: Re: [Dev] D-Bus + Cynara On Fri, 2014-08-01 at 21:37 +0200, Lukasz Wojciechowski wrote: > Jacek will be grateful for code You left. Probably You both can > synchronize after this 2 weeks, when You'll be back. > > On Cynara side, we started work on asynchronous API yesterday. > Marcin Niesluchowski is the person that is responsible for that task as > I plan also to go to holiday. > He will share draft of API next week on mailing list. I noticed that the async API was merged (https://review.tizen.org/gerrit/25416) without discussing it on the list first. I think it would have been better to get a +1 from all relevant users of the new API (Jacek for dbus-daemon, someone else for Crosswalk). Jacek left some comments, but I see nothing from the Crosswalk team. I'm not particularly happy about how the asynchronous API was completely separated from the synchronous API (even the constants are defined twice!). Is mixing the synchronous and asynchronous API in the same process possible? The documentation leaves some questions open (what is the caller supposed to do with the file descriptor?). Anyway, I think it is usable for dbus-daemon. Jacek, have you perhaps started to verify that by writing code? -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. _______________________________________________ Dev mailing list [email protected] https://lists.tizen.org/listinfo/dev _______________________________________________ Dev mailing list [email protected] https://lists.tizen.org/listinfo/dev
