Hi Zhang Zhengguang,
As I told you in review https://review.tizen.org/gerrit/#/c/29712/ I
cannot connect to an AP using your patches adding multi-user support in
connman.
I use tizen-common_20141104.3 image on VTC1010.
I uninstalled net-config, updated connman and installed
capi-network-wifi, capi-network-wifi-test, connman-lib, winet and winet-lib.
Then I connect as user alice, launch
/usr/lib64/winet-capi-test/capi-wifi-test and perform the following
actions in this application:
1 (Wi-Fi init and set callbacks)
Event received from stdin
Wifi init succeeded
Operation finished!
5 (Is Wi-Fi activated?)
Event received from stdin
Success to get Wi-Fi device state : TRUE
Operation finished!
6 (Get connection state)
Event received from stdin
Success to get connection state : Disconnected
Operation finished!
7 (Scan request)
Event received from stdin
Scan request succeeded
Operation finished!
b (Get AP list)
Event received from stdin
AP name : 0104
AP BSSID : e0:46:9a:08:8e:db, state : Disconnected
AP name : EUROGICIEL
AP BSSID : 04:a1:51:83:f5:d0, state : Disconnected
AP name : DIRECT-GO-wfd-eurogiciel
AP BSSID : 62:02:b4:07:87:5e, state : Disconnected
AP name : FreeWifi
AP BSSID : f4:ca:e5:c4:b0:1d, state : Disconnected
AP name : Livebox-0ee9
AP BSSID : 00:19:70:74:90:e3, state : Disconnected
AP name : Wifi_Breitinfo
AP BSSID : 50:67:f0:39:23:3e, state : Disconnected
Get AP list finished
Operation finished!
c (Connect)
Event received from stdin
Input a BSSID to connect : 04:a1:51:83:f5:d0
get AP ap_bssid_input 04:a1:51:83:f5:d0, BSSID [e0:46:9a:08:8e:db]
get AP ap_bssid_input 04:a1:51:83:f5:d0, BSSID [04:a1:51:83:f5:d0]
Input passphrase for 04:a1:51:83:f5:d0 : ************
Success to connection request [04:a1:51:83:f5:d0]
Connection step finished
Operation finished!
Wi-Fi Connection Failed! error : OPERATION_FAILEDEvent received from stdin
6 (Get connection state)
Event received from stdin
Success to get connection state : Disconnected
Operation finished!
a (Get Connected AP)
Event received from stdin
Fail to get essid [INVALID_PARAMETER]
Operation failed!
You will find the connman log in attachment.
If I apply the patch in attachment to connman, I can connect to the AP.
Regards,
Nicolas Guyomard
Le 28/10/2014 01:59, Zhang, Zhengguang a écrit :
Hi, All
WiNet multi-user solution related patches have been updated and optimized,
please help to review it again, thanks in advance!
https://review.tizen.org/gerrit/#/c/28918/
https://review.tizen.org/gerrit/#/c/28921/
https://review.tizen.org/gerrit/#/c/28922/
https://review.tizen.org/gerrit/#/c/28923/
https://review.tizen.org/gerrit/#/c/28924/
Regards,
Zhang Zhengguang
-----Original Message-----
From: Von Dentz, Luiz [mailto:[email protected]]
Sent: Friday, October 17, 2014 3:32 PM
To: Zhang, Zhengguang
Cc: Dominig ar Foll (Intel OTC); Nicolas Guyomard; [email protected]; Liu,
Bingwei
Subject: Re: [Dev] winet multi-user feature
Hi,
Apparently you guys are not synchronizing with Bluetooth, anyway this looks
better but if you are doing a blocking call to GetConnectionUnixUser perhaps
it is better to use dbus_bus_get_unix_user since it is probably doing the same
thing anyway.
On Fri, Oct 17, 2014 at 9:22 AM, Zhang, Zhengguang
<[email protected]> wrote:
Hi, Dominique
We have finished the phrase 1 source code in ConnMan to meet WiNet
multi-user requirements, and submitted them to gerrit:
https://review.tizen.org/gerrit/#/c/28918/
https://review.tizen.org/gerrit/#/c/28921/
https://review.tizen.org/gerrit/#/c/28922/
https://review.tizen.org/gerrit/#/c/28923/
https://review.tizen.org/gerrit/#/c/28924/
I have verified the solution and found it can meet the requirements,
please help to review the patches and any suggestions, feel free to
let me know, thanks in advance!
Regards,
Zhang Zhengguang
From: Dev [mailto:[email protected]] On Behalf Of Dominig ar
Foll (Intel OTC)
Sent: Wednesday, October 8, 2014 4:30 PM
Cc: [email protected]
Subject: Re: [Dev] winet multi-user feature
Zhang,
happy to see that you have plan to deliver the required feature.
When will we see the code ?
"Nicolas Guyomard" <[email protected]> will be the
engineer in charge of the integration in Common once your code is ready.
He is present on this list.
Regards
Dominig ar Foll
Senior Software Architect
Open Source Technology Centre
Intel SSG
Le 08/10/2014 10:03, Zhang, Zhengguang a écrit :
Hi, Dominique
After our investigation about how to implement WiNet multi-user
requirements, we found that it’s the right way to implement it in
ConnMan, the reason is described below:
1. ConnMan is the real connection manager daemon, and it should
handle
multi-user related stuff logically. WiNet service daemon is only a
slim daemon which is designed to make some background operations, such
as trigger periodically scan, tethering data statistics and son on.
2. ConnMan has already supported a feature “Session” which can
be used
to implement multi-user, but we found that it’s not mature enough and
a little too complicated, after a balance about the schedule and the
solution, our proposal solution is:
1). At the first phrase, add ConnMan patches ourselves to implement
multi-user and maintain them in Tizen ConnMan, by our investigation,
we only need less than 5 patches to implement the requirement. It’s
not a problem to maintain the related patches in Tizen and not submit
them to upstream, actually, we have already maintained more than 20
patches in Tizen ConnMan to meet Samsung specific requirements, which
can’t be merged into ConnMan upstream. So Tizen ConnMan is a little
different with upstream Connman:
upstream ConnMan is common to every platform, but Tizen ConnMan is
specific for Tizen platform.
2). At the second phrase, when multi-user requirements is nailed down
completely and ConnMan session is mature, we will continue to
investigate it and try to switch the solution to ConnMan session.
Currently at the first stage, we will submit the related patches to
gerrit, we will add you guys as the reviewers, any suggestions about
it, feel free to let me know, thanks!
Regards,
Zhang Zhengguang
_______________________________________________
Dev mailing list
[email protected]
https://lists.tizen.org/listinfo/dev
-- Logs begin at mer. 2014-11-05 04:51:13 PST, end at mer. 2014-11-05 04:56:28 PST. --
nov. 05 04:51:14 common_box connmand[183]: Connection Manager version 1.26
nov. 05 04:51:14 common_box connmand[183]: Checking loopback interface settings
nov. 05 04:51:14 common_box connmand[183]: System hostname is common_box
nov. 05 04:51:14 common_box connmand[183]: lo {newlink} index 1 address 00:00:00:00:00:00 mtu 65536
nov. 05 04:51:14 common_box connmand[183]: lo {newlink} index 1 operstate 0 <UNKNOWN>
nov. 05 04:51:14 common_box connmand[183]: enp1s0 {create} index 2 type 1 <ETHER>
nov. 05 04:51:14 common_box connmand[183]: enp1s0 {update} flags 4098 <DOWN>
nov. 05 04:51:14 common_box connmand[183]: enp1s0 {newlink} index 2 address 00:10:F3:38:42:DB mtu 1500
nov. 05 04:51:14 common_box connmand[183]: enp1s0 {newlink} index 2 operstate 2 <DOWN>
nov. 05 04:51:15 common_box connmand[183]: Adding interface enp1s0 [ ethernet ]
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {create} index 3 type 1 <ETHER>
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {update} flags 4098 <DOWN>
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {newlink} index 3 address 0C:8B:FD:CA:10:CA mtu 1500
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {newlink} index 3 operstate 2 <DOWN>
nov. 05 04:51:15 common_box connmand[183]: Adding interface wlp2s0 [ wifi ]
nov. 05 04:51:15 common_box connmand[183]: enp1s0 {update} flags 36867 <UP>
nov. 05 04:51:15 common_box connmand[183]: enp1s0 {newlink} index 2 address 00:10:F3:38:42:DB mtu 1500
nov. 05 04:51:15 common_box connmand[183]: enp1s0 {newlink} index 2 operstate 2 <DOWN>
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {update} flags 36931 <UP,RUNNING>
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {newlink} index 3 address 0C:8B:FD:CA:10:CA mtu 1500
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {newlink} index 3 operstate 0 <UNKNOWN>
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {update} flags 36867 <UP>
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {newlink} index 3 address 0C:8B:FD:CA:10:CA mtu 1500
nov. 05 04:51:15 common_box connmand[183]: wlp2s0 {newlink} index 3 operstate 2 <DOWN>
nov. 05 04:51:15 common_box connmand[183]: Method "ListAdapters" with signature "" on interface "org.bluez.Manager" doesn't exist
nov. 05 04:51:18 common_box connmand[183]: enp1s0 {add} route fe80:: gw :: scope 0 <UNIVERSE>
nov. 05 04:51:18 common_box connmand[183]: enp1s0 {update} flags 102467 <UP,RUNNING,LOWER_UP>
nov. 05 04:51:18 common_box connmand[183]: enp1s0 {newlink} index 2 address 00:10:F3:38:42:DB mtu 1500
nov. 05 04:51:18 common_box connmand[183]: enp1s0 {newlink} index 2 operstate 6 <UP>
nov. 05 04:51:18 common_box connmand[183]: Skipping disconnect of carrier, network is connecting.
nov. 05 04:51:24 common_box connmand[183]: Setting domainname to eurogiciel.fr
nov. 05 04:51:24 common_box connmand[183]: enp1s0 {add} address 192.168.22.163/24 label enp1s0 family 2
nov. 05 04:51:24 common_box connmand[183]: ntp: time slew -54.194598 s
nov. 05 04:50:29 common_box connmand[183]: enp1s0 {add} route 192.168.22.0 gw 0.0.0.0 scope 253 <LINK>
nov. 05 04:50:29 common_box connmand[183]: enp1s0 {add} route 192.168.22.254 gw 0.0.0.0 scope 253 <LINK>
nov. 05 04:50:29 common_box connmand[183]: enp1s0 {add} route 10.21.0.1 gw 192.168.22.254 scope 0 <UNIVERSE>
nov. 05 04:50:29 common_box connmand[183]: enp1s0 {add} route 0.0.0.0 gw 192.168.22.254 scope 0 <UNIVERSE>
nov. 05 04:50:29 common_box connmand[183]: enp1s0 {add} route 87.106.208.187 gw 192.168.22.254 scope 0 <UNIVERSE>
nov. 05 04:50:29 common_box connmand[183]: enp1s0 {del} route 87.106.208.187 gw 192.168.22.254 scope 0 <UNIVERSE>
diff --git a/src/service.c b/src/service.c
index 84095ec..f9dfbdb 100644
--- a/src/service.c
+++ b/src/service.c
@@ -6091,19 +6091,18 @@ static int service_connect(struct connman_service *service)
case CONNMAN_SERVICE_SECURITY_PSK:
case CONNMAN_SERVICE_SECURITY_WPA:
case CONNMAN_SERVICE_SECURITY_RSN:
- if (!service->passphrase) {
+ if (service->request_passphrase_input) {
+ DBG("Now try to connect other user's favorite service");
+ service->request_passphrase_input = false;
+ return -ENOKEY;
+ } else if (!service->passphrase) {
if (!service->network)
return -EOPNOTSUPP;
if (!service->wps ||
!connman_network_get_bool(service->network, "WiFi.UseWPS"))
return -ENOKEY;
- } else if (service->request_passphrase_input) {
- DBG("Now try to connect other user's favorite service");
- service->request_passphrase_input = false;
- return -ENOKEY;
- }
- break;
+ }break;
case CONNMAN_SERVICE_SECURITY_8021X:
if (!service->eap)
_______________________________________________
Dev mailing list
[email protected]
https://lists.tizen.org/listinfo/dev
