Hi all, > I speak about the review > https://review.tizen.org/gerrit/#/c/31701/
What are we doing here? Is it again public shaming with pointing fingers? I don't like where this community is going. Someone made a change, which some people (reviewers/maintainers) don't like. Also this person put too much confidence in this change by putting +2 and verify by himself. Tell me, why taking care of this problem on gerrit review isn't enough? Why, seeing there might be problem with putting on your own commit accept/verify, you didn't address it here in general, but had to point fingers? I could point fingers at some, that had not only accepted and verified they own commits, but also merged them in less than 3 minutes. But how would it be better? This kind of messages make this community unpleasant. The change wasn't merged, so it wasn't forced, so what is the real problem? > The "We want Kdbus ..." is not an agreed general feature but can only > be, as today, a valid profile specific request. > So the patch as it is shall be rejected :-( What do you mean rejected? Put -1, -2 on review? Then do this, the change wasn't merged, so what is the problem? > In order to get it in, the same person pushed it, verified it, and > accept it in less than 2 hours of working day time in Europe where are > located the Common reviewers. > Sorry but that is not acceptable. Still not merged. I don't see any "getting in" nor "forcing" here. I see (maybe) wrong way of saying - I know we need this change. > 1) Same person submitting, verifying and accepting a patch (even > simple) is not in line with Tizen review model, This happened many times in the past, by different persons. Why wasn't it addressed earlier? > 2) A decent time should be left for reviewer to voice their concerns. > Typical 24h to cover multiple time zones. There is still time - seeing your mail and the change not being merged. > So please do not force changes any more. > (...) > Please accept my apologies for having to be a bit rude. I really, really don't get this. Why did you have to be rude? Why was the change forced? I don't like how sometimes things are trying to be taken care of on mailing list. I hope in future we can work together in less rude and more civilized way. Best regards, Zofia Abramowska. _______________________________________________ Dev mailing list Dev@lists.tizen.org https://lists.tizen.org/listinfo/dev
