On Fri, Dec 30, 2022 at 12:43:18PM -0500, Robert Middleton wrote:
> On Fri, Dec 30, 2022 at 11:43 AM Tobias Frost <t...@debian.org> wrote:
> > When doing the same against the branch "next_stable", currently at [2]
> > the result is much much worse:
> > https://people.debian.org/~tobi/log4cxx/1_to_next/compat_report.html
> >
> > /me confusedā€¦ (I've read your text as it should be the oppositeā€¦)
> >
> 
> The new version should be ABI stable moving forward, but it needs to
> be released first.
> 
> > If it is only API compatible, but not ABI compable, we'll need a SONAME 
> > bump.
> >
> 
> I bumped the SONAME a little bit ago; you probably grabbed the code
> shortly before I bumped it.

Indeed :)

> I think I've done it correctly, but it
> would be nice to have somebody double-check it.  I arbitrarily bumped
> it to version 15, skipping 14.  The version of the SO file should also
> now match the version of log4cxx, but that version is not the same as
> the SONAME.

The generated file names look strange:

Now:
tobi@isildor:~/workspace/deb/packages/log4cxx/upstream/log4cxx/debian/tmp/usr/lib/x86_64-linux-gnu$
 ls -la liblog4cxx*
lrwxrwxrwx 1 tobi tobi       20 Dec 31 08:51 liblog4cxx.so -> 
liblog4cxx.so.15.0.0
-rw-r--r-- 1 tobi tobi 22632496 Dec 31 08:50 liblog4cxx.so.1.0.0.0
lrwxrwxrwx 1 tobi tobi       21 Dec 31 08:51 liblog4cxx.so.15.0.0 -> 
liblog4cxx.so.1.0.0.0

I'd expect the (actually) library be liblog4cxx.so.15.0.0 and symlinks pointing 
to it:
liblog4cxx.so --> liblog4cxx.so.15 --> liblog4cxx.so.15.0.0
(linker name) --> (soname)        --> (real name)

(References: https://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html,
 https://man7.org/conf/lca2006/shared_libraries/slide5b.html and following 
slides)

before it was like this, which matches what I see on other libraries and what I 
would expect:
tobi@isildor:~/workspace/deb/packages/log4cxx/log4cxx/debian/tmp/usr/lib/x86_64-linux-gnu$
 ls -la liblog4cxx*
total 22780
lrwxrwxrwx 1 tobi tobi       16 Dec 31 08:55 liblog4cxx.so -> liblog4cxx.so.13
lrwxrwxrwx 1 tobi tobi       20 Dec 31 08:55 liblog4cxx.so.13 -> 
liblog4cxx.so.13.0.0
-rw-r--r-- 1 tobi tobi 23308784 Dec 31 08:54 liblog4cxx.so.13.0.0
)

(If you want to encode the project version into the name, it would be more
liblog4cxx-1.0.0.so, liblog4cxx-1.0.0.so.15 and sliblog4cxx-1.0.0.so.15.0.0 , 
but that's breaking
the concept of soanmes alltogether, as for the linker/loader 
liblog4cxx-1.0.0.so.15 and liblog4cxx-1.0.1.so.15 would
be different, unrelated libraries)

> -Robert Middletona

-- 
tobi

Reply via email to