Hi all, Do note that building from sources, not git, is an Apache requirement. IIRC reproducibility is a nice-to-have for Apache, but are we making this a Logging or Log4J requirement? So a review should not be based on a git tag IMO, it should be based on downloading the src zip or tar and building from that, which is what a Linux distribution that builds everything from first principles would do.
Gary On Tue, Dec 19, 2023, 3:31 AM Piotr P. Karwasz <piotr.karw...@gmail.com> wrote: > Hi Gary, > > On Thu, 14 Dec 2023 at 21:39, Gary Gregory <garydgreg...@gmail.com> wrote: > > If you write "Please don't release this.", then you should vote -1. Or > am I > > missing something? > > You are right. I am voting -1, because of the `*-test-sources.jar` > artifacts in the Maven repository. > > Reproducibility is not an issue, we just need to use the Git tag > instead of the source archive. > > Piotr >