[
https://issues.apache.org/jira/browse/LUCENE-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-2480:
-------------------------------
Attachment: LUCENE-2480.patch
Thanks Earwin ! Few comments:
* You didn't remove the .zip indexes?
* You removed the code from TestBackwardsCompatibilty which creates the older
indexes. While this isn't needed currently for trunk - the code is commented
out, and I don't think it bothers anyone - one day, after 4.0 is released, we
will need to use it. So I don't think we should remove that piece of code.
* TestIndexFileDeleter failed 'cause of deletable file - fixed it.
Attached is the merged patch, w/ the above fixes. Solr tests fail
(*.dataimport.* tests) for some reason. I don't understand this yet - so if
someone more knowledgeable about Solr than me cares to take a look, I'd
appreciate it. I see many things like that (not sure how those tests are
related to this issue):
{code}
[junit]
[junit] request was: q=id:500&start=0&qt=standard&version=2.2&rows=20
[junit] junit.framework.AssertionFailedError: now it should query failed
XPath: //resu...@numfound=1]
[junit] xml response was: <?xml version="1.0" encoding="UTF-8"?>
[junit] <response>
[junit] <lst name="responseHeader"><int name="status">0</int><int
name="QTime">16</int></lst><result name="response" numFound="0" start="0"/>
[junit] </response>
[junit]
[junit] request was: q=id:500&start=0&qt=standard&version=2.2&rows=20
[junit] at
org.apache.solr.util.AbstractSolrTestCase.assertQ(AbstractSolrTestCase.java:236)
[junit] at
org.apache.solr.update.AutoCommitTest.testMaxTime(AutoCommitTest.java:218)
{code}
> Remove support for pre-3.0 indexes
> ----------------------------------
>
> Key: LUCENE-2480
> URL: https://issues.apache.org/jira/browse/LUCENE-2480
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Shai Erera
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2480.patch, LUCENE-2480.patch, LUCENE-2480.patch
>
>
> We should remove support for 2.x (and 1.9) indexes in 4.0. It seems that
> nothing can be done in 3x because there is no special code which handles 1.9,
> so we'll leave it there. This issue should cover:
> # Remove the .zip indexes
> # Remove the unnecessary code from SegmentInfo and SegmentInfos. Mike
> suggests we compare the version headers at the top of SegmentInfos, in 2.9.x
> vs 3.0.x, to see which ones can go.
> # remove FORMAT_PRE from FieldInfos
> # Remove old format from TermVectorsReader
> If you know of other places where code can be removed, then please post a
> comment here.
> I don't know when I'll have time to handle it, definitely not in the next few
> days. So if someone wants to take a stab at it, be my guest.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
