[
https://issues.apache.org/jira/browse/LUCENE-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874214#action_12874214
]
Michael McCandless commented on LUCENE-2311:
--------------------------------------------
bq. It is also arguably more concise and clear to call warm() on all newly
created segments, so there is a single point of warming readers in NRT context,
and every subreader coming from getReader is guaranteed to be warmed up -> you
don't have to introduce even more mess in your code by rechecking it.
I agree this would be nice, however... it's less important that this be called
from within IW, because this warming time (on newly flushed segments) must be
done in the foreground of the reopen thread. Ie, whether we do this in IW or
app does it externally, this will block an NRT reader turnaround.
Vs warming a newly merged segment, where we have the freedom to continue using
the old (merged) segments until the newly merged one is warmed.
> Pass potent SR to IRWarmer.warm(), and also call warm() for new segments
> ------------------------------------------------------------------------
>
> Key: LUCENE-2311
> URL: https://issues.apache.org/jira/browse/LUCENE-2311
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9.3, 3.0.2, 3.1, 4.0
>
> Attachments: LUCENE-2311.patch
>
>
> Currently warm() receives a SegmentReader without terms index and docstores.
> It would be arguably more useful for the app to receive a fully loaded
> reader, so it can actually fire up some caches. If the warmer is undefined on
> IW, we probably leave things as they are.
> It is also arguably more concise and clear to call warm() on all newly
> created segments, so there is a single point of warming readers in NRT
> context, and every subreader coming from getReader is guaranteed to be warmed
> up -> you don't have to introduce even more mess in your code by rechecking
> it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
