[
https://issues.apache.org/jira/browse/LUCENE-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874634#action_12874634
]
Earwin Burrfoot commented on LUCENE-2311:
-----------------------------------------
bq. Does your pending patch (what's the issue number again?) do this already?
LUCENE-2355 - this patch doesn't do this yet.
The next part removes the need for readerWarmer, as each reader has a number of
components that are notified when reader is created/closed (and can warm
themselves appropriately).
This also takes care of one of Yonik's concerns from LUCENE-2485
bq.Passing in the complete index (in addition to just the new segment) would
allow incremental updating of an index-wide data structure
The factories that create components are shared for DirReader+SRs or
IW-readerPool+SRs+IWBackedReader, so new components by default have access to
index-wide context.
The part that is missing is the way for the user to specify if he wants his
newly merged SRs pre-warmed and up to which runlevel.
> Pass potent SR to IRWarmer.warm(), and also call warm() for new segments
> ------------------------------------------------------------------------
>
> Key: LUCENE-2311
> URL: https://issues.apache.org/jira/browse/LUCENE-2311
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Index
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Fix For: 2.9.3, 3.0.2, 3.1, 4.0
>
> Attachments: LUCENE-2311.patch, LUCENE-2311.patch
>
>
> Currently warm() receives a SegmentReader without terms index and docstores.
> It would be arguably more useful for the app to receive a fully loaded
> reader, so it can actually fire up some caches. If the warmer is undefined on
> IW, we probably leave things as they are.
> It is also arguably more concise and clear to call warm() on all newly
> created segments, so there is a single point of warming readers in NRT
> context, and every subreader coming from getReader is guaranteed to be warmed
> up -> you don't have to introduce even more mess in your code by rechecking
> it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
