[ 
https://issues.apache.org/jira/browse/SOLR-1682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12883913#action_12883913
 ] 

Yonik Seeley commented on SOLR-1682:
------------------------------------

bq.  >  these aren't valid if the group is every discarded then re-added. keep 
track if there have been discards?
bq. I think this means that we have to keep all groups in memory.

I guess it depends... if this is the first phase only (just to find the top 
groups) then we don't really need the counts.  If the collapse count is one... 
then we need to either fix the counts another way, and potentially provide an 
option to not return the counts.

bq. Also we need to find a way of adding the collapse information to the 
response in a nice manner. I assume we still want the use the response format 
Shalin suggested? It does differ from the response the patch is currently 
generating.

My prototype was just quick'n'dirty just to get the info out to the response 
writer to see if it worked.
But I'm not yet sure what the response format should be (and I've changed my 
mind before based on what types of usecases I'm thinking about).  For usecases 
like bestbuy (do a search for something like DVD to see their field 
collapsing), the grouping is pretty explicit and it seems to make sense to 
return multiple lists of documents.  One may also want to have a different sort 
in grouped documents, and for that it makes little sense to try and combine 
them all into a single list.  It's also the case that people may often want a 
fixed number of groups, rather than a fixed number of documents.  Also, it's 
possible that people may want to group on more than one field (like people 
facet on more than one field).

There are other use cases where collapsed docs are more of an exception and the 
traditional single-doc-list would be better.  But instead of trying to 
implement all these variants at once, I'm thinking of starting with a more 
generic groupedResults separate from normal results.  We can add options later 
for an alternate flattened representation.



> Implement CollapseComponent
> ---------------------------
>
>                 Key: SOLR-1682
>                 URL: https://issues.apache.org/jira/browse/SOLR-1682
>             Project: Solr
>          Issue Type: Sub-task
>          Components: search
>            Reporter: Martijn van Groningen
>            Assignee: Shalin Shekhar Mangar
>             Fix For: Next
>
>         Attachments: field-collapsing.patch, SOLR-1682.patch, 
> SOLR-1682.patch, SOLR-1682_prototype.patch, SOLR-1682_prototype.patch, 
> SOLR-236.patch
>
>
> Child issue of SOLR-236. This issue is dedicated to field collapsing in 
> general and all its code (CollapseComponent, DocumentCollapsers and 
> CollapseCollectors). The main goal is the finalize the request parameters and 
> response format.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to