[ 
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910699#action_12910699
 ] 

Yonik Seeley edited comment on LUCENE-2649 at 9/17/10 2:01 PM:
---------------------------------------------------------------

bq. Let's try to find some baby-step (even if not clean - we know FieldCache, 
somehow, needs to be fixed more generally) for today?

The cheapest option might be:

{code}
  public interface Parser extends Serializable {
    public boolean recordMissing();
  }
{code}

A better option is to replace FieldCache.Parser in SortField to be 
FieldCache.EntryCreator.

Oh, and if we're recording all the set bits, it would be really nice to record 
both
- the number of values set
- the number of unique values encountered

Both should be zero or non-measurable cost (a counter++ that does not produce a 
data dependency can be executed in parallel on a free int execution unit)


      was (Author: ysee...@gmail.com):
    bq. Let's try to find some baby-step (even if not clean - we know 
FieldCache, somehow, needs to be fixed more generally) for today?

The cheapest option might be:

{quote}
  public interface Parser extends Serializable {
    public boolean recordMissing();
  }
{quote}

A better option is to replace FieldCache.Parser in SortField to be 
FieldCache.EntryCreator.

Oh, and if we're recording all the set bits, it would be really nice to record 
both
- the number of values set
- the number of unique values encountered

Both should be zero or non-measurable cost (a counter++ that does not produce a 
data dependency can be executed in parallel on a free int execution unit)

  
> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
>                 Key: LUCENE-2649
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2649
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 4.0
>
>         Attachments: LUCENE-2649-FieldCacheWithBitSet.patch, 
> LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.  
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a 
> BitSet for all valid docs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to