[
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910803#action_12910803
]
Ryan McKinley commented on LUCENE-2649:
---------------------------------------
Maybe, but I'm still not sure this cleans things up enough to be worth the
trouble -- ideally the API should be easy to have consistent results. I don't
like that it would be too easy to mess things up if you the application does
not use the same parser from various components (that may be in different
libraries etc). Conceptually it makes sense to have settings about what is or
is not cached attached to the FieldCache itself, not to the things that ask the
FieldCache for its values -- and letting whoever asks first set the behavior
for the next guy who asks (regardless of what they ask for!).
If we are going to make it essentially required to always pass in the right
Parser/EntryCreator, we should at least remove all the ways of not passing one
in -- since that call is saying "use what ever is there, and the next guy who
asks should be ok with it too"
Does something like the EntryCreator idea fix -- or at least begin to fix --
the other FieldCache issues? If not, is it really worth introducing just to
avoid a static variable?
I think the best near term option is live with the static initializer, and fix
it when the we rework the FieldCache to fix a host of other issues. For solr
the default will be set to always calculate, for lucene... we will let Mike and
Uwe duke it out :)
> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
> Key: LUCENE-2649
> URL: https://issues.apache.org/jira/browse/LUCENE-2649
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Fix For: 4.0
>
> Attachments: LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a
> BitSet for all valid docs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
