[
https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921686#action_12921686
]
Robert Muir commented on LUCENE-2671:
-------------------------------------
I am concerned about the @SuppressWarnings here, for two reasons:
# I don't think we should use this except in limited circumstances where its
not our fault (see below)
# I don't think we should leave the API broken pending some massive "rework
fieldcache" issue, which it appears has been attempted before...
# I don't understand the generics in the current API at all
In general with SuppressWarnings, i think we should limit our uses to cases
where its really a false warning
* generic collections/array problems
* documenting intentional fallthroughs in switch statements
* possibly autogenerated code from something else like javacc/jflex
I'd like for us to remove the SuppressWarnings and look at what we can do to
fix the API right now as-is.
> Add sort missing first/last ability to SortField and ValueComparator
> --------------------------------------------------------------------
>
> Key: LUCENE-2671
> URL: https://issues.apache.org/jira/browse/LUCENE-2671
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Search
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 4.0
>
> Attachments: LUCENE-2671-SortMissingLast.patch,
> LUCENE-2671-suppress-unchecked.patch
>
>
> When SortField and ValueComparator use EntryCreators (from LUCENE-2649) they
> use a special sort value when the field is missing.
> This enables lucene to implement 'sort missing last' or 'sort missing first'
> for numeric values from the FieldCache.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
