[ 
https://issues.apache.org/jira/browse/LUCENE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923426#action_12923426
 ] 

Michael McCandless commented on LUCENE-2618:
--------------------------------------------

{quote}
If close(false) is called after optimize() was called, it means the app would 
like to abort merges ASAP. If so, why would we consult the MP if we're 
instructed to abort?

Are you talking about a different use case?
{quote}

Sorry, different use case.

This use case is you call .optimize(doWait=false) then you call a normal 
.close() (ie, wait for merges).  In this case we wait for all running merges to 
finish, but don't start any new ones.  My patch would still allow new ones to 
start if the merges are due to a running optimize.

Your use case, where .close(false) is called, will in fact abort all running 
merges and close quickly.  Ie we will not start new merges, even for optimize, 
if you pass false to close, with this pattch.

> Intermittent failure in 3.x's backwards TestThreadedOptimize
> ------------------------------------------------------------
>
>                 Key: LUCENE-2618
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2618
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>            Reporter: Michael McCandless
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2618.patch
>
>
> Failure looks like this:
> {noformat}
>     [junit] Testsuite: org.apache.lucene.index.TestThreadedOptimize
>     [junit] Testcase: 
> testThreadedOptimize(org.apache.lucene.index.TestThreadedOptimize):     FAILED
>     [junit] null
>     [junit] junit.framework.AssertionFailedError: null
>     [junit]   at 
> org.apache.lucene.index.TestThreadedOptimize.runTest(TestThreadedOptimize.java:125)
>     [junit]   at 
> org.apache.lucene.index.TestThreadedOptimize.testThreadedOptimize(TestThreadedOptimize.java:149)
>     [junit]   at 
> org.apache.lucene.util.LuceneTestCase.runBare(LuceneTestCase.java:253)
> {noformat}
> I just committed some verbosity so next time it strikes we'll have more 
> details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to