[
https://issues.apache.org/jira/browse/LUCENE-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923579#action_12923579
]
Shai Erera commented on LUCENE-2618:
------------------------------------
I don't personally mind either way. Just want to point out that calling
maybeMerge is as explicit as calling optimize. You can argue for both that if
an app wants to wait for merges it can call waitForMerges. In fact, an app
calling close() already stated it wants to wait for merges - it's as if it
called waitForMerges followed by close.
I think you're trying to distinguish merges that started because the MP decided
they should run following a certain commit to those triggered by explicit call
to optimize. So IMO maybeMerge and optimize are the same as both were
explicitly initiated by the application.
This test fails because it assumes optimize will run to completion. What if the
test assumed maybeMerge runs to completion? Isn't that a valid expectation from
an application calling close()? We're also distinguishing the first round of
merges from subsequent rounds, only when maybeMerge is called, but not
optimize...
> Intermittent failure in 3.x's backwards TestThreadedOptimize
> ------------------------------------------------------------
>
> Key: LUCENE-2618
> URL: https://issues.apache.org/jira/browse/LUCENE-2618
> Project: Lucene - Java
> Issue Type: Bug
> Components: Index
> Reporter: Michael McCandless
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2618.patch
>
>
> Failure looks like this:
> {noformat}
> [junit] Testsuite: org.apache.lucene.index.TestThreadedOptimize
> [junit] Testcase:
> testThreadedOptimize(org.apache.lucene.index.TestThreadedOptimize): FAILED
> [junit] null
> [junit] junit.framework.AssertionFailedError: null
> [junit] at
> org.apache.lucene.index.TestThreadedOptimize.runTest(TestThreadedOptimize.java:125)
> [junit] at
> org.apache.lucene.index.TestThreadedOptimize.testThreadedOptimize(TestThreadedOptimize.java:149)
> [junit] at
> org.apache.lucene.util.LuceneTestCase.runBare(LuceneTestCase.java:253)
> {noformat}
> I just committed some verbosity so next time it strikes we'll have more
> details.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
